You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2026/09/15 06:17:13 UTC

[Impala-ASF-CR] IMPALA-15037: Add profile counters for HBO

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24844


Change subject: IMPALA-15037: Add profile counters for HBO
......................................................................

IMPALA-15037: Add profile counters for HBO

This patch adds the following profile counters for HBO:
- HBOStats.HitCount: Number of reads that found the key in the cache.
- HBOStats.ReadCount: Number of cache-backend lookups performed.
- HBOStats.ReadTime: Time spent reading HBO stats from the cache.
- HBOStats.TotalTime: Total time in using HBO stats, including time spent
  in generating HBO key strings.

Testing
 - Add e2e tests

Assisted-by: Opus 4.8 (Claude Code)
Change-Id: Ief6235094df8a16a283c395f74486d71c46bb142
---
M fe/src/main/java/org/apache/impala/planner/PlanNode.java
M fe/src/main/java/org/apache/impala/service/HistoricalStats.java
M tests/query_test/test_observability.py
3 files changed, 93 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/24844/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief6235094df8a16a283c395f74486d71c46bb142
Gerrit-Change-Number: 24844
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-15037: Add profile counters for HBO

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24844 )

Change subject: IMPALA-15037: Add profile counters for HBO
......................................................................


Patch Set 1: Code-Review+2

Giving this a +2 because
1) This is fairly simple
2) Past reviews from Aleksandr have been thorough.


-- 
To view, visit http://gerrit.cloudera.org:8080/24844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6235094df8a16a283c395f74486d71c46bb142
Gerrit-Change-Number: 24844
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Sep 2026 16:08:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15037: Add profile counters for HBO

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24844 )

Change subject: IMPALA-15037: Add profile counters for HBO
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6235094df8a16a283c395f74486d71c46bb142
Gerrit-Change-Number: 24844
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Sep 2026 20:58:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15037: Add profile counters for HBO

Posted by "Nandor Kollar (Code Review)" <ge...@cloudera.org>.
Nandor Kollar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24844 )

Change subject: IMPALA-15037: Add profile counters for HBO
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6235094df8a16a283c395f74486d71c46bb142
Gerrit-Change-Number: 24844
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Sep 2026 19:35:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15037: Add profile counters for HBO

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24844 )

Change subject: IMPALA-15037: Add profile counters for HBO
......................................................................

IMPALA-15037: Add profile counters for HBO

This patch adds the following profile counters for HBO:
- HBOStats.HitCount: Number of reads that found the key in the cache.
- HBOStats.ReadCount: Number of cache-backend lookups performed.
- HBOStats.ReadTime: Time spent reading HBO stats from the cache.
- HBOStats.TotalTime: Total time in using HBO stats, including time spent
  in generating HBO key strings.

Testing
 - Add e2e tests

Assisted-by: Opus 4.8 (Claude Code)
Change-Id: Ief6235094df8a16a283c395f74486d71c46bb142
Reviewed-on: http://gerrit.cloudera.org:8080/24844
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/planner/PlanNode.java
M fe/src/main/java/org/apache/impala/service/HistoricalStats.java
M tests/query_test/test_observability.py
3 files changed, 93 insertions(+), 16 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief6235094df8a16a283c395f74486d71c46bb142
Gerrit-Change-Number: 24844
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>

[Impala-ASF-CR] IMPALA-15037: Add profile counters for HBO

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24844 )

Change subject: IMPALA-15037: Add profile counters for HBO
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6235094df8a16a283c395f74486d71c46bb142
Gerrit-Change-Number: 24844
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Sep 2026 16:19:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15037: Add profile counters for HBO

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24844 )

Change subject: IMPALA-15037: Add profile counters for HBO
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6235094df8a16a283c395f74486d71c46bb142
Gerrit-Change-Number: 24844
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2026 06:10:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15037: Add profile counters for HBO

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24844 )

Change subject: IMPALA-15037: Add profile counters for HBO
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14171/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6235094df8a16a283c395f74486d71c46bb142
Gerrit-Change-Number: 24844
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Sep 2026 16:19:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15037: Add profile counters for HBO

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24844 )

Change subject: IMPALA-15037: Add profile counters for HBO
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24020/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6235094df8a16a283c395f74486d71c46bb142
Gerrit-Change-Number: 24844
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 06:40:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15037: Add profile counters for HBO

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24844 )

Change subject: IMPALA-15037: Add profile counters for HBO
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6235094df8a16a283c395f74486d71c46bb142
Gerrit-Change-Number: 24844
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Sep 2026 18:05:25 +0000
Gerrit-HasComments: No