[GitHub] [spark] LucaCanali commented on pull request #29203: [SPARK-32409][CORE] Remove dependency between spark.metrics.staticSources.enabled and JVMSource registration

[GitBox <gi...@apache.org>]

LucaCanali commented on pull request #29203:
URL: https://github.com/apache/spark/pull/29203#issuecomment-663404226


   @dongjoon-hyun thank you very much for your quick reply on this and the comments.
   My bad, I had forgotten about #22279. There are solid reasons to skip JVM Source registration for YARN Application Master case, as discussed there.
   
   I can see a couple of options to move this forward:
   - One alternative is to add an additional flag as an argument to the start method, so that JVMClass registration can be done in the general case, but also be skipped for the YARN AM case, as in the WIP code I just pushed.
   - Alternatively, we can consider the current behavior (dependency of the config spark.metrics.register.static.sources.enabled and JVM Class registration) as acceptable and simply refocus this into a documentation PR, that is documenting the behavior in the monitoring doc.
   
   Any thoughts?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org