You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "MarcusSorealheis (via GitHub)" <gi...@apache.org> on 2023/03/22 07:18:40 UTC
[GitHub] [solr] MarcusSorealheis opened a new pull request, #1479: SOLR-16465: Replace Login w/ React App
MarcusSorealheis opened a new pull request, #1479:
URL: https://github.com/apache/solr/pull/1479
[SOLR-16465](https://issues.apache.org/jira/browse/SOLR-16465)
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
This PR will replace the login screen functionality with new, modern technologies.
# Solution
The solution combines React, Material, and other standard technologies using permissive licenses to lay the foundation of a new Solr Admin UI, beginning with the login experience. Most importantly, the approach is meant to use the same infrastructure Solr uses for configuring, building, and deploying software so it does not become a burden.
# Tests
The test is basic and only checks to ensure that the new app renders in the browser and contains text from the login page. In the future, this approach can be extended to support testing complex data manipulations or other exploration.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] MarcusSorealheis commented on pull request #1479: SOLR-16465: Replace Login w/ React App
Posted by "MarcusSorealheis (via GitHub)" <gi...@apache.org>.
MarcusSorealheis commented on PR #1479:
URL: https://github.com/apache/solr/pull/1479#issuecomment-1479031217
Obviously a lot of work still to do, some of it really obvious, but I see light at the end of the tunnel. Forgive me if there are any silly mistakes that pop out. I'm mostly a data person wherever in the stack, it's been a while with these technologies. Doing the janitorial.
if you want to try it out and don't want to run the gradle task in Intellij or Eclipse, you can simply navigate to solr/solr-ui-login (we will remove login in a future iteration), you can run `npm start`. That should do the trick. Please let me know if you have any questions. Happy to help as I can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] MarcusSorealheis commented on pull request #1479: SOLR-16465: Replace Login w/ React App
Posted by "MarcusSorealheis (via GitHub)" <gi...@apache.org>.
MarcusSorealheis commented on PR #1479:
URL: https://github.com/apache/solr/pull/1479#issuecomment-1492824628
As is the nature of these things, I need to blow away a lot of the work to take a different approach. As I mentioned before, it had been a while since I dusted off my JS chops. Looks like Create React Aoo has died after many years being the scaffolding leader. I'm going to take a new approach and I'm sure developers will be enthusiastic to work with the new framework and approach I will push up in a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] MarcusSorealheis commented on pull request #1479: SOLR-16465: Replace Login w/ React App
Posted by "MarcusSorealheis (via GitHub)" <gi...@apache.org>.
MarcusSorealheis commented on PR #1479:
URL: https://github.com/apache/solr/pull/1479#issuecomment-1501064933
> Please reach out if you need insight into current Admin UI. As you may know, Solr backend is 100% stateless, so there is no "login" as such. The current Admin UI will do the auth, caching Authorization header in browser storage, and pass in on all subsequent reqeusts to Solr backend.
Will do for sure probably beginning this week as I think I've done sufficient research to have an opinion on the best approach. Haven't pushed it up yet but will very soon. I am aware of the backend being stateless.
> Question: Is the goal still to host the entire Admin UI, including old non-ported angular-pages, from the new "modern" Admin App? Or do you plan to have two independent Admin apps and send users between them?
I think the best approach is to host both the non-ported and ported UI's at the same time for a while. Given the scope and complexity, it will take some time for us to port over. I think the best path is to chip away at it here over the next 9 months until it is entirely ported over. Over time, I expecting porting to accelerate dramatically, and that estimate could be way overblown. There's also the fact that part of the decision I've chosen the framework that I have chosen is that it is extremely modern, seeing a lot of investment, and makes many strong choices about design.
I'm detailing the approach in a document for the next community meeting where people can review and comment, in addition to pushing up the example here shortly. The first example I started with was fine, but the framework and approach that was very popular for 6+ years is now obsolete. This approach is newer and should be good for another 6-10 years, which will be vital for preventing the situation that hit us more recently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1479: SOLR-16465: Replace Login w/ React App
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1479:
URL: https://github.com/apache/solr/pull/1479#issuecomment-1497426584
Please reach out if you need insight into current Admin UI. As you may know, Solr backend is 100% stateless, so there is no "login" as such. The current Admin UI will do the auth, caching Authorization header in browser storage, and pass in on all subsequent reqeusts to Solr backend.
Question: Is the goal still to host the entire Admin UI, including old non-ported angular-pages, from the new "modern" Admin App? Or do you plan to have two independent Admin apps and send users between them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org