[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11975: Performance Optimization

["AlbumenJ (via GitHub)" <gi...@apache.org>]

AlbumenJ commented on code in PR #11975:
URL: https://github.com/apache/dubbo/pull/11975#discussion_r1159379324


##########
dubbo-common/src/main/java/org/apache/dubbo/rpc/executor/AbstractIsolationExecutorSupport.java:
##########
@@ -50,15 +50,17 @@ public Executor getExecutor(Object data) {
 
         for (URL serviceUrl : serviceUrls) {
             if (serviceUrl.getProtocol().equals(url.getProtocol()) && serviceUrl.getPort() == url.getPort()) {
-                return executorRepository.getExecutor(serviceUrl);
+                return executorRepository.getExecutor(providerModel, serviceUrl);
             }
         }
-        return executorRepository.getExecutor(serviceUrls.get(0));
+        return executorRepository.getExecutor(providerModel, serviceUrls.get(0));
     }
 
-    protected abstract ServiceKey getServiceKey(Object data);
+    protected ServiceKey getServiceKey(Object data) {

Review Comment:
   Dubbo Protocol do not need to override this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org