You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ke...@apache.org on 2020/12/16 15:24:08 UTC

[skywalking-python] branch master updated: Fix: BaseExceptions not recorded as errors (#104)

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-python.git


The following commit(s) were added to refs/heads/master by this push:
     new b6f6edd  Fix: BaseExceptions not recorded as errors (#104)
b6f6edd is described below

commit b6f6edd73bad4ad1b7390990b17721cea208c15d
Author: Tomasz Pytel <to...@gmail.com>
AuthorDate: Wed Dec 16 12:23:58 2020 -0300

    Fix: BaseExceptions not recorded as errors (#104)
---
 skywalking/trace/span.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/skywalking/trace/span.py b/skywalking/trace/span.py
index 24fa0f2..70c9dcb 100644
--- a/skywalking/trace/span.py
+++ b/skywalking/trace/span.py
@@ -116,7 +116,7 @@ class Span(ABC):
         return self
 
     def __exit__(self, exc_type, exc_val, exc_tb):
-        if isinstance(exc_val, BaseException):
+        if isinstance(exc_val, Exception):
             self.raised()
         self.stop()
         if exc_tb is not None: