[Bug 7265] DNS resolving breaks with Net::DNS 1.03

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7265

--- Comment #10 from Quanah Gibson-Mount <qu...@zimbra.com> ---
(In reply to Mark Martinec from comment #8)

> --- lib/Mail/SpamAssassin/Plugin/DKIM.pm        (revision 1715244)
> +++ lib/Mail/SpamAssassin/Plugin/DKIM.pm        (working copy)
> @@ -794,7 +794,8 @@
>          # Only do so if EDNS0 provides a reasonably-sized UDP payload size,
>          # as our interface does not provide a DNS fallback to TCP, unlike
>          # the Net::DNS::Resolver::send which does provide it.
> -        my $res = $self->{main}->{resolver}->get_resolver;
> +        my $res = $self->{main}->{resolver};
> +        dbg("dkim: providing our own resolver: %s", ref $res);
>          Mail::DKIM::DNS::resolver($res);
>        }
>      }

I think this fix is incomplete, as Mail::DKIM also uses the Net::DNS resolver
at:

              if (Mail::DKIM::AuthorDomainPolicy->UNIVERSAL::can("fetch")) {
                dbg("dkim: adsp: performing lookup on _adsp._domainkey.%s",
                    $author_domain);
                # get our Net::DNS::Resolver object
                my $res = $self->{main}->{resolver}->get_resolver;
                $practices = Mail::DKIM::AuthorDomainPolicy->fetch(
                               Protocol => "dns", Domain => $author_domain,
                               DnsResolver => $res);
              }
              1;

which is around line 1046 in DKIM.pm.  I would expect we want to use the native
resolver in both places?

-- 
You are receiving this mail because:
You are the assignee for the bug.