You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/07/11 23:53:35 UTC
Review Request 71061: Added limits validation for `UPDATE_QUOTA` call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71061/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9812
https://issues.apache.org/jira/browse/MESOS-9812
Repository: mesos
Description
-------
The validation checks the newly requested limits against
its current consumption. If a role's consumption is already
more than the limits, the update request will be denied
(unless force flag is set to true).
Also added a test.
Diffs
-----
src/master/quota_handler.cpp 13789d8461fcf029837b15b567ac1b7b97677607
src/tests/master_quota_tests.cpp a1b37693b74778ff6827c9325f1f9225ecf73e58
Diff: https://reviews.apache.org/r/71061/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 71061: Added limits validation for `UPDATE_QUOTA`
call.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71061/#review216545
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71061]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 11, 2019, 11:53 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71061/
> -----------------------------------------------------------
>
> (Updated July 11, 2019, 11:53 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9812
> https://issues.apache.org/jira/browse/MESOS-9812
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The validation checks the newly requested limits against
> its current consumption. If a role's consumption is already
> more than the limits, the update request will be denied
> (unless force flag is set to true).
>
> Also added a test.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 13789d8461fcf029837b15b567ac1b7b97677607
> src/tests/master_quota_tests.cpp a1b37693b74778ff6827c9325f1f9225ecf73e58
>
>
> Diff: https://reviews.apache.org/r/71061/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71061: Added limits validation for `UPDATE_QUOTA`
call.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71061/#review216563
-----------------------------------------------------------
Ship it!
Perhaps a note about MESOS-9888 in the commit description?
src/master/quota_handler.cpp
Lines 479-480 (patched)
<https://reviews.apache.org/r/71061/#comment303775>
Quotes on same line?
Do we also want to show the consumption and limit here? might be helpful for the operator to see, e.g.
Quota update for 'foo-role' sets quota limit (XXX) below quota consumption (YYY); ignored violation since the force flag is provided
src/master/quota_handler.cpp
Lines 484 (patched)
<https://reviews.apache.org/r/71061/#comment303776>
; this is ...
src/tests/master_quota_tests.cpp
Lines 1340 (patched)
<https://reviews.apache.org/r/71061/#comment303777>
s/updated/update/ ?
- Benjamin Mahler
On July 11, 2019, 11:53 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71061/
> -----------------------------------------------------------
>
> (Updated July 11, 2019, 11:53 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9812
> https://issues.apache.org/jira/browse/MESOS-9812
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The validation checks the newly requested limits against
> its current consumption. If a role's consumption is already
> more than the limits, the update request will be denied
> (unless force flag is set to true).
>
> Also added a test.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 13789d8461fcf029837b15b567ac1b7b97677607
> src/tests/master_quota_tests.cpp a1b37693b74778ff6827c9325f1f9225ecf73e58
>
>
> Diff: https://reviews.apache.org/r/71061/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71061: Added limits validation for `UPDATE_QUOTA`
call.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71061/
-----------------------------------------------------------
(Updated July 17, 2019, 6:56 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Updated after MESOS-9888
Bugs: MESOS-9812
https://issues.apache.org/jira/browse/MESOS-9812
Repository: mesos
Description
-------
The validation checks the newly requested limits against
its current consumption. If a role's consumption is already
more than the limits, the update request will be denied
(unless force flag is set to true).
Also added a test.
Diffs (updated)
-----
src/master/quota_handler.cpp 2a3ca5640c850ec8a8aca7abed45386b5b5e1125
src/tests/master_quota_tests.cpp 64a9b31a38af23fb16a4afd04f6d3413c7d1ffe9
Diff: https://reviews.apache.org/r/71061/diff/2/
Changes: https://reviews.apache.org/r/71061/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu