You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by ravikiran23 <gi...@git.apache.org> on 2016/09/20 18:27:44 UTC
[GitHub] incubator-carbondata pull request #181: [CARBONDATA-261] clean files is upda...
GitHub user ravikiran23 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/181
[CARBONDATA-261] clean files is updating the stale segment status.
PROBLEM:
in clean files it will read the table status first and it will delete the physical locations and update the table metadata and then take the lock for writing and after that it will write the old read list to the file.
but this is wrong as in the time between the read and write the table status would have been changed.
so before writing it should read the table status again and update the changes and then write.
SOLUTION:
before writing the status read the table status again and update the changes and then write.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravikiran23/incubator-carbondata cleanfilesdefect
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #181
----
commit 96f220f60d76b1ff63beff8516c0812c1033cd08
Author: ravikiran <ra...@gmail.com>
Date: 2016-09-20T18:05:17Z
in clean files it will read the table status first and it will delete the physical locations and update the table metadata and then take the lock for writing and after that it will write the old read list to the file.
but this is wrong as in the time between the read and write the table status would have been changed.
so before writing it should read the table status again and update the changes and then write.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #181: [CARBONDATA-261] clean files is upda...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---