You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/14 11:41:02 UTC
[GitHub] [spark] yaooqinn commented on a change in pull request #31479: [SPARK-34373][SQL] HiveThriftServer2 startWithContext may hang with a race issue
yaooqinn commented on a change in pull request #31479:
URL: https://github.com/apache/spark/pull/31479#discussion_r575795780
##########
File path: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
##########
@@ -197,6 +200,10 @@ public synchronized void stop() {
LOG.error("Error stopping Http server: ", e);
}
}
+ if (serverThread != null) {
+ serverThread.interrupt();
+ serverThread = null;
+ }
Review comment:
thanks @dongjoon-hyun. I will check this soon after Chinese New Year Festival😁
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org