You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/27 23:42:40 UTC

[GitHub] sandeep-krishnamurthy opened a new pull request #12691: [MXNET-1001] [WIP] Add new cudnn_tune, cudnn_off params in gluon conv blocks

sandeep-krishnamurthy opened a new pull request #12691: [MXNET-1001] [WIP] Add new cudnn_tune, cudnn_off params in gluon conv blocks
URL: https://github.com/apache/incubator-mxnet/pull/12691
 
 
   ## Description ##
   Add support for two flags - `cudnn_tune` and `cudnn_off` for conv blocks in Gluon.
   These options are already supported in symbolic APIs. In this change, we basically take that as param and pass it to underlying ndarray/symbolic APIs.
   
   fixes https://github.com/apache/incubator-mxnet/issues/11342
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [X] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [X] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [X] Support cudnn_tune and cudnn_off params in gluon conv blocks
   - [ ] Add tests to test cudnn_tune and cudnn_off in gluon conv blocks
   
   ## Comments ##
   Pending:
   1. Adding more test case and testing the behavior.
   2. Verify API docs are generated correctly.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services