You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2022/02/11 13:51:35 UTC
[camel] 01/09: (chores) camel-maven-package-plugin: use final variables and fields when possible
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit d4fc4cc3798e7debd45b2ebe48f18c6669efbaae
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Feb 11 11:39:09 2022 +0100
(chores) camel-maven-package-plugin: use final variables and fields when possible
---
.../java/org/apache/camel/maven/packaging/PrepareCatalogMojo.java | 2 +-
.../dsl/component/ComponentDslBuilderFactoryGenerator.java | 2 +-
.../packaging/dsl/component/ComponentsBuilderFactoryGenerator.java | 2 +-
.../packaging/dsl/component/ComponentsDslMetadataRegistry.java | 6 +++---
.../camel/maven/packaging/generics/OwbGenericArrayTypeImpl.java | 2 +-
.../apache/camel/maven/packaging/generics/OwbTypeVariableImpl.java | 6 +++---
.../apache/camel/maven/packaging/generics/OwbWildcardTypeImpl.java | 4 ++--
7 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCatalogMojo.java b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCatalogMojo.java
index 3aa2f12..1c06890 100644
--- a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCatalogMojo.java
+++ b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCatalogMojo.java
@@ -198,7 +198,7 @@ public class PrepareCatalogMojo extends AbstractMojo {
private Collection<Path> allJsonFiles;
private Collection<Path> allPropertiesFiles;
- private Map<Path, BaseModel<?>> allModels = new HashMap<>();
+ private final Map<Path, BaseModel<?>> allModels = new HashMap<>();
private static String asComponentName(Path file) {
String name = file.getFileName().toString();
diff --git a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/dsl/component/ComponentDslBuilderFactoryGenerator.java b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/dsl/component/ComponentDslBuilderFactoryGenerator.java
index 4e58672..e377880 100644
--- a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/dsl/component/ComponentDslBuilderFactoryGenerator.java
+++ b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/dsl/component/ComponentDslBuilderFactoryGenerator.java
@@ -35,7 +35,7 @@ public final class ComponentDslBuilderFactoryGenerator {
private final ComponentModel componentModel;
private final String packageName;
- private JavaClass javaClass;
+ private final JavaClass javaClass;
private ComponentDslInnerBuilderGenerator componentDslInnerBuilderGenerator;
private ComponentDslInnerImplBuilderGenerator componentDslInnerImplBuilderGenerator;
diff --git a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/dsl/component/ComponentsBuilderFactoryGenerator.java b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/dsl/component/ComponentsBuilderFactoryGenerator.java
index e7df1ee..284e9b5 100644
--- a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/dsl/component/ComponentsBuilderFactoryGenerator.java
+++ b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/dsl/component/ComponentsBuilderFactoryGenerator.java
@@ -38,7 +38,7 @@ public final class ComponentsBuilderFactoryGenerator {
private final String packageName;
private final Set<ComponentModel> componentModels;
- private JavaClass javaClass;
+ private final JavaClass javaClass;
private ComponentsBuilderFactoryGenerator(final Set<ComponentModel> componentModels, final ClassLoader classLoader,
final String packageName) {
diff --git a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/dsl/component/ComponentsDslMetadataRegistry.java b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/dsl/component/ComponentsDslMetadataRegistry.java
index ab73b57..7f9bc62 100644
--- a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/dsl/component/ComponentsDslMetadataRegistry.java
+++ b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/dsl/component/ComponentsDslMetadataRegistry.java
@@ -41,9 +41,9 @@ import static org.apache.camel.tooling.util.PackageHelper.loadText;
*/
public class ComponentsDslMetadataRegistry {
- private Map<String, ComponentModel> componentsCache;
- private Set<String> componentsDslFactories;
- private File metadataFile;
+ private final Map<String, ComponentModel> componentsCache;
+ private final Set<String> componentsDslFactories;
+ private final File metadataFile;
public ComponentsDslMetadataRegistry(final File componentDslDir, final File metadataFile) {
// First: Load the content of the metadata file into memory
diff --git a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/generics/OwbGenericArrayTypeImpl.java b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/generics/OwbGenericArrayTypeImpl.java
index 501580d..47fa6d2 100644
--- a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/generics/OwbGenericArrayTypeImpl.java
+++ b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/generics/OwbGenericArrayTypeImpl.java
@@ -21,7 +21,7 @@ import java.lang.reflect.Type;
public class OwbGenericArrayTypeImpl implements GenericArrayType {
- private Type componentType;
+ private final Type componentType;
public OwbGenericArrayTypeImpl(Type componentType) {
this.componentType = componentType;
diff --git a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/generics/OwbTypeVariableImpl.java b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/generics/OwbTypeVariableImpl.java
index f3c73eb..93af431 100644
--- a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/generics/OwbTypeVariableImpl.java
+++ b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/generics/OwbTypeVariableImpl.java
@@ -49,9 +49,9 @@ public class OwbTypeVariableImpl {
public static class OwbTypeVariableInvocationHandler implements InvocationHandler {
- private String name;
- private GenericDeclaration genericDeclaration;
- private Type[] bounds;
+ private final String name;
+ private final GenericDeclaration genericDeclaration;
+ private final Type[] bounds;
public OwbTypeVariableInvocationHandler(TypeVariable typeVariable, Type... bounds) {
name = typeVariable.getName();
diff --git a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/generics/OwbWildcardTypeImpl.java b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/generics/OwbWildcardTypeImpl.java
index 14bb1de..458d7e5 100644
--- a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/generics/OwbWildcardTypeImpl.java
+++ b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/generics/OwbWildcardTypeImpl.java
@@ -21,8 +21,8 @@ import java.lang.reflect.WildcardType;
public class OwbWildcardTypeImpl implements WildcardType {
- private Type[] upperBounds;
- private Type[] lowerBounds;
+ private final Type[] upperBounds;
+ private final Type[] lowerBounds;
public OwbWildcardTypeImpl(Type[] upperBounds, Type[] lowerBounds) {
this.upperBounds = upperBounds.clone();