You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "iloveeyjafjalla (via GitHub)" <gi...@apache.org> on 2026/10/17 04:26:45 UTC

[I] [Bug] The message and DLQ range filters offer a clear control that does nothing [rocketmq-dashboard]

iloveeyjafjalla opened a new issue, #6891:
URL: https://github.com/apache/rocketmq-dashboard/issues/6891

   ## Summary
   
   Three range filters in the instance pages offer a clear control that does nothing: the topic-query window on the message page, and the export window and resend window on the DLQ page.
   
   Clicking the clear (×) inside those pickers has no effect: the picker's value snaps back and the next query/export/resend reuses the previous window, with nothing telling the user that the range they tried to remove is still applied.
   
   ## Why
   
   All three are controlled pickers whose `onChange` drops a cleared value because the state is a non-null tuple:
   
   - `web/src/pages/instance/message.tsx:1236-1245` — `value={dateRange}`, `onChange={(vals) => { if (vals && vals[0] && vals[1]) setDateRange(...) }}`.
   - `web/src/pages/instance/dlq.tsx:711-721` (export) and `:842-851` (resend) — the same shape.
   
   The request side has no empty state to clear to: the ranges are initialized when the page mounts, and every request carries them unconditionally — the topic query sends `startTime/endTime` (`message.tsx:546`), the export sends `exportRange` (`dlq.tsx:352`, `:402`, `:467`) and the resend sends `retryRange` (`:312`). So the control offered something the page cannot represent.
   
   ## Impact
   
   A user who clears the range to widen the query or the export sees the control revert and the old window silently applied. Nothing on the page says the window is mandatory or which default is in force.
   
   ## Reproduction
   
   `web/src/pages/instance/__tests__/MessagePage.test.tsx` → `offers no clear control on the query window it always sends`, and `DLQPage.test.tsx` → `offers no clear control on the windows the export and the resend always send`:
   
   ```
   AssertionError: expected <span …(2)>…(1)</span> to be null
   ```
   
   (the `.ant-picker-clear` element renders today on each of the three pickers, including the one inside the resend dialog).
   
   ## Expected
   
   The three pickers do not offer a clear the page cannot honour; changing the window stays available through the picker itself.
   
   Not the same as #6791/#6792: that is the notification-deliveries page and a one-sided range not being applied — these pickers always send a full range.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] The message and DLQ range filters offer a clear control that does nothing [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6891:
URL: https://github.com/apache/rocketmq-dashboard/issues/6891#issuecomment-6391322549

   This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] The message and DLQ range filters offer a clear control that does nothing [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #6891: [Bug] The message and DLQ range filters offer a clear control that does nothing
URL: https://github.com/apache/rocketmq-dashboard/issues/6891


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org