You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "liuyongvs (via GitHub)" <gi...@apache.org> on 2023/06/13 05:56:39 UTC
[GitHub] [calcite] liuyongvs opened a new pull request, #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
liuyongvs opened a new pull request, #3262:
URL: https://github.com/apache/calcite/pull/3262
[map_concat](https://spark.apache.org/docs/latest/api/sql/index.html#map_concat)
map_concat(map, ...) - Returns the union of all the given maps
Examples:
```
> SELECT map_concat(map(1, 'a', 2, 'b'), map(3, 'c'));
{1:"a",2:"b",3:"c"}
```
[map_from_entries](https://spark.apache.org/docs/latest/api/sql/index.html#map_from_entries)
map_from_entries(arrayOfEntries) - Returns a map created from the given array of entries.
Examples:
```
> SELECT map_from_entries(array(struct(1, 'a'), struct(2, 'b')));
{1:"a",2:"b"}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] MasseGuillaume commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "MasseGuillaume (via GitHub)" <gi...@apache.org>.
MasseGuillaume commented on code in PR #3262:
URL: https://github.com/apache/calcite/pull/3262#discussion_r1237043630
##########
site/_docs/reference.md:
##########
@@ -2740,9 +2740,11 @@ BigQuery's type system uses confusingly different names for types and functions:
| m | TO_BASE64(string) | Converts the *string* to base-64 encoded form and returns a encoded string
| b m | FROM_BASE64(string) | Returns the decoded result of a base-64 *string* as a string
| b o | LTRIM(string) | Returns *string* with all blanks removed from the start
+| s | MAP_CONCAT(map [, map]*) | Concatenates one or more maps. If any input argument is `NULL` the function returns `NULL`
Review Comment:
https://github.com/apache/calcite/pull/3238#discussion_r1222473808
We should document somewhere that Calcite is using the LAST_WIN strategy. Ideally we could make this configurable, but that's annother PR/JIRA issue.
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -5646,6 +5646,33 @@ private static void checkIf(SqlOperatorFixture f) {
+ "'SORT_ARRAY\\(<ARRAY>, <BOOLEAN>\\)'", false);
}
+ /** Tests {@code MAP_CONCAT} function from Spark. */
+ @Test void testMapConcatFunc() {
+ final SqlOperatorFixture f0 = fixture();
+ f0.setFor(SqlLibraryOperators.MAP_CONCAT);
+ f0.checkFails("^map_concat(map['foo', 1], map['bar', 2])^",
+ "No match found for function signature MAP_CONCAT\\("
+ + "<\\(CHAR\\(3\\), INTEGER\\) MAP>, <\\(CHAR\\(3\\), INTEGER\\) MAP>\\)", false);
+
+ final SqlOperatorFixture f = f0.withLibrary(SqlLibrary.SPARK);
+ f.checkScalar("map_concat(map['foo', 1], map['bar', 2])", "{foo=1, bar=2}",
+ "(CHAR(3) NOT NULL, INTEGER NOT NULL) MAP NOT NULL");
+ f.checkScalar("map_concat(map['foo', 1], map['bar', 2], map['foo', 2])", "{foo=2, bar=2}",
+ "(CHAR(3) NOT NULL, INTEGER NOT NULL) MAP NOT NULL");
+ f.checkScalar("map_concat(map[null, 1], map[null, 2])", "{null=2}",
+ "(NULL, INTEGER NOT NULL) MAP NOT NULL");
+ f.checkScalar("map_concat(map[1, 2], map[1, null])", "{1=null}",
+ "(INTEGER NOT NULL, INTEGER) MAP NOT NULL");
+ f.checkNull("map_concat(map['foo', 1], null)");
+ f.checkType("map_concat(map['foo', 1], null)", "(CHAR(3) NOT NULL, INTEGER NOT NULL) MAP");
+ f.checkNull("map_concat(null, map['foo', 1])");
+ f.checkType("map_concat(null, map['foo', 1])", "(CHAR(3) NOT NULL, INTEGER NOT NULL) MAP");
+ f.checkFails("^map_concat()^", INVALID_ARGUMENTS_NUMBER, false);
Review Comment:
```
spark.sql("select map_concat()").show
+------------+
|map_concat()|
+------------+
| {}|
+------------+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1606719734
rebase to fix conflicts with main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liuyongvs commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on code in PR #3262:
URL: https://github.com/apache/calcite/pull/3262#discussion_r1241057944
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -1020,12 +1022,32 @@ private static RelDataType arrayReturnType(SqlOperatorBinding opBinding) {
ReturnTypes.ARG0_NULLABLE,
OperandTypes.ARRAY.or(OperandTypes.ARRAY_BOOLEAN_LITERAL));
+ private static RelDataType deriveTypeMapConcat(SqlOperatorBinding opBinding) {
+ if (opBinding.getOperandCount() == 0) {
+ final RelDataTypeFactory typeFactory = opBinding.getTypeFactory();
+ final RelDataType type = typeFactory.createSqlType(SqlTypeName.VARCHAR);
+ requireNonNull(type, "type");
+ return SqlTypeUtil.createMapType(typeFactory, type, type, true);
+ } else {
+ final List<RelDataType> operandTypes = opBinding.collectOperandTypes();
+ for (RelDataType operandType: operandTypes) {
+ if (!SqlTypeUtil.isMap(operandType)) {
+ throw opBinding.newError(
+ RESOURCE.typesShouldAllBeMap(
+ opBinding.getOperator().getName(),
+ operandType.getFullTypeString()));
Review Comment:
comments:
we need check every arg whether it is map.
```
spark-sql (default)> select map_concat(map('foo', 1), null);
[DATATYPE_MISMATCH.MAP_CONCAT_DIFF_TYPES] Cannot resolve "map_concat(map(foo, 1), NULL)" due to data type mismatch: The `map_concat` should all be of type map, but it's ["MAP<STRING, INT>", "VOID"].; line 1 pos 7;
'Project [unresolvedalias(map_concat(map(foo, 1), null), None)]
+- OneRowRelation
spark-sql (default)> select map_concat(map('foo', 1), cast(null as map<string, int>));
NULL
```
and i also add the tests. but we can have 2 different implementation here.
1) check operand type in return type inference. the implementation is simple
2) check operand type in operand type inference.
```
public static final SqlFunction MAP_CONCAT =
SqlBasicFunction.create(SqlKind.MAP_CONCAT,
SqlLibraryOperators::deriveTypeMapConcat,
OperandTypes.SAME_VARIADIC.and(OperandTypes.ALL_ARGS_MAP));
private static class AllArgsMapOperandTypeChecker
implements SqlSingleOperandTypeChecker {
@Override public boolean checkSingleOperandType(SqlCallBinding callBinding,
SqlNode node, int iFormalOperand, boolean throwOnFailure) {
RelDataType type = SqlTypeUtil.deriveType(callBinding, node);
boolean valid = false;
if (type.getSqlTypeName() == SqlTypeName.MAP) {
valid = true;
}
if (!valid && throwOnFailure) {
throw callBinding.newError(
RESOURCE.typesShouldAllBeMap(
callBinding.getOperator().getName(),
type.getFullTypeString()));
}
return valid;
}
@Override public SqlOperandCountRange getOperandCountRange() {
return SqlOperandCountRanges.any();
}
@Override public String getAllowedSignatures(SqlOperator op, String opName) {
....
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liuyongvs merged pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs merged PR #3262:
URL: https://github.com/apache/calcite/pull/3262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liuyongvs commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on code in PR #3262:
URL: https://github.com/apache/calcite/pull/3262#discussion_r1241682226
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3984,6 +3985,13 @@ public static List sortArray(List list, boolean ascending) {
return list;
}
+ /** Support the MAP_CONCAT function. */
+ public static Map mapConcat(Map... maps) {
+ final Map result = new LinkedHashMap();
+ Arrays.stream(maps).forEach(result::putAll);
Review Comment:
@zoudan thanks for your suggestion. i think it makes code clear, so i will not change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1595914028
Hi @JiajunBernoulli do you have time to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1590829365
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3262)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list) [96.8% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] zoudan commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "zoudan (via GitHub)" <gi...@apache.org>.
zoudan commented on code in PR #3262:
URL: https://github.com/apache/calcite/pull/3262#discussion_r1241483640
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3984,6 +3985,13 @@ public static List sortArray(List list, boolean ascending) {
return list;
}
+ /** Support the MAP_CONCAT function. */
+ public static Map mapConcat(Map... maps) {
+ final Map result = new LinkedHashMap();
+ Arrays.stream(maps).forEach(result::putAll);
Review Comment:
I have an impression that lambda expressions have performance issues in certain scenarios in jdk8, but I haven't found clear evidence yet, so it is ok if you want to keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liuyongvs commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on code in PR #3262:
URL: https://github.com/apache/calcite/pull/3262#discussion_r1227567195
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -1005,6 +1012,23 @@ private static RelDataType arrayReturnType(SqlOperatorBinding opBinding) {
ReturnTypes.TO_MAP_VALUES_NULLABLE,
OperandTypes.MAP);
+ private static RelDataType deriveTypeMapFromEntries(SqlOperatorBinding opBinding) {
+ final RelDataType entriesType = opBinding.collectOperandTypes().get(0);
+ final RelDataType entryType = entriesType.getComponentType();
+ return SqlTypeUtil.createMapType(
+ opBinding.getTypeFactory(),
+ requireNonNull(entryType.getFieldList().get(0).getType(), "inferred key type"),
+ requireNonNull(entryType.getFieldList().get(1).getType(), "inferred value type"),
+ entriesType.isNullable() || entryType.isNullable());
+ }
+
Review Comment:
comments:
```
comments:
because my other prs will conflict it, so i don't submit it now. so i add an summary:
the spark MAP_FROM_ENTRIES nullable have 2 case:
1) input is nullable
2) array, which contains null entry like this ,it will also return null
so we should take this into consideration, type and result, i will add comment in the pr when you review you will see
// spark
spark-sql> select map_from_entries(array(struct(1, 'a'), null));
NULL
// calcite should test this
f.checkNull("map_from_entries(array[row(1, 'a'), null])");
f.checkType("map_from_entries(array[row(1, 'a'), null])",
"(INTEGER, CHAR(1)) MAP");
case class MapFromEntries(child: Expression)
extends UnaryExpression
with NullIntolerant
with QueryErrorsBase {
@transient
private lazy val dataTypeDetails: Option[(MapType, Boolean, Boolean)] = child.dataType match {
case ArrayType(
StructType(Array(
StructField(_, keyType, keyNullable, _),
StructField(_, valueType, valueNullable, _))),
containsNull) => Some((MapType(keyType, valueType, valueNullable), keyNullable, containsNull))
case _ => None
}
@transient private lazy val nullEntries: Boolean = dataTypeDetails.get._3
override def nullable: Boolean = child.nullable || nullEntries
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1588822290
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3262)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list) [96.8% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] zoudan commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "zoudan (via GitHub)" <gi...@apache.org>.
zoudan commented on code in PR #3262:
URL: https://github.com/apache/calcite/pull/3262#discussion_r1233680551
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3984,6 +3985,13 @@ public static List sortArray(List list, boolean ascending) {
return list;
}
+ /** Support the MAP_CONCAT function. */
+ public static Map mapConcat(Map... maps) {
+ final Map result = new LinkedHashMap();
+ Arrays.stream(maps).forEach(result::putAll);
Review Comment:
I prefer not to use lambda expressions for performance reasons, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liuyongvs commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on code in PR #3262:
URL: https://github.com/apache/calcite/pull/3262#discussion_r1227567195
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -1005,6 +1012,23 @@ private static RelDataType arrayReturnType(SqlOperatorBinding opBinding) {
ReturnTypes.TO_MAP_VALUES_NULLABLE,
OperandTypes.MAP);
+ private static RelDataType deriveTypeMapFromEntries(SqlOperatorBinding opBinding) {
+ final RelDataType entriesType = opBinding.collectOperandTypes().get(0);
+ final RelDataType entryType = entriesType.getComponentType();
+ return SqlTypeUtil.createMapType(
+ opBinding.getTypeFactory(),
+ requireNonNull(entryType.getFieldList().get(0).getType(), "inferred key type"),
+ requireNonNull(entryType.getFieldList().get(1).getType(), "inferred value type"),
+ entriesType.isNullable() || entryType.isNullable());
+ }
+
Review Comment:
comments:
```
the spark MAP_FROM_ENTRIES nullable have 2 case:
1) input is nullable
2) array, which contains null entry like this ,it will also return null
// spark
spark-sql> select map_from_entries(array(struct(1, 'a'), null));
NULL
// calcite should test this
f.checkNull("map_from_entries(array[row(1, 'a'), null])");
f.checkType("map_from_entries(array[row(1, 'a'), null])",
"(INTEGER, CHAR(1)) MAP");
case class MapFromEntries(child: Expression)
extends UnaryExpression
with NullIntolerant
with QueryErrorsBase {
@transient
private lazy val dataTypeDetails: Option[(MapType, Boolean, Boolean)] = child.dataType match {
case ArrayType(
StructType(Array(
StructField(_, keyType, keyNullable, _),
StructField(_, valueType, valueNullable, _))),
containsNull) => Some((MapType(keyType, valueType, valueNullable), keyNullable, containsNull))
case _ => None
}
@transient private lazy val nullEntries: Boolean = dataTypeDetails.get._3
override def nullable: Boolean = child.nullable || nullEntries
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1589093164
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3262)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list) [96.8% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1605901738
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3262)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list) [97.4% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liuyongvs commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on code in PR #3262:
URL: https://github.com/apache/calcite/pull/3262#discussion_r1241057944
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -1020,12 +1022,32 @@ private static RelDataType arrayReturnType(SqlOperatorBinding opBinding) {
ReturnTypes.ARG0_NULLABLE,
OperandTypes.ARRAY.or(OperandTypes.ARRAY_BOOLEAN_LITERAL));
+ private static RelDataType deriveTypeMapConcat(SqlOperatorBinding opBinding) {
+ if (opBinding.getOperandCount() == 0) {
+ final RelDataTypeFactory typeFactory = opBinding.getTypeFactory();
+ final RelDataType type = typeFactory.createSqlType(SqlTypeName.VARCHAR);
+ requireNonNull(type, "type");
+ return SqlTypeUtil.createMapType(typeFactory, type, type, true);
+ } else {
+ final List<RelDataType> operandTypes = opBinding.collectOperandTypes();
+ for (RelDataType operandType: operandTypes) {
+ if (!SqlTypeUtil.isMap(operandType)) {
+ throw opBinding.newError(
+ RESOURCE.typesShouldAllBeMap(
+ opBinding.getOperator().getName(),
+ operandType.getFullTypeString()));
Review Comment:
comments:
we need check every arg whether it is map. and i also add the tests. but we can have 2 different implementation here.
1) check operand type in return type inference. the implementation is simple
2) check operand type in operand type inference.
```
public static final SqlFunction MAP_CONCAT =
SqlBasicFunction.create(SqlKind.MAP_CONCAT,
SqlLibraryOperators::deriveTypeMapConcat,
OperandTypes.SAME_VARIADIC.and(OperandTypes.ALL_ARGS_MAP));
private static class AllArgsMapOperandTypeChecker
implements SqlSingleOperandTypeChecker {
@Override public boolean checkSingleOperandType(SqlCallBinding callBinding,
SqlNode node, int iFormalOperand, boolean throwOnFailure) {
RelDataType type = SqlTypeUtil.deriveType(callBinding, node);
boolean valid = false;
if (type.getSqlTypeName() == SqlTypeName.MAP) {
valid = true;
}
if (!valid && throwOnFailure) {
throw callBinding.newError(
RESOURCE.typesShouldAllBeMap(
callBinding.getOperator().getName(),
type.getFullTypeString()));
}
return valid;
}
@Override public SqlOperandCountRange getOperandCountRange() {
return SqlOperandCountRanges.any();
}
@Override public String getAllowedSignatures(SqlOperator op, String opName) {
....
}
}
```
```
spark-sql (default)> select map_concat(map('foo', 1), null);
[DATATYPE_MISMATCH.MAP_CONCAT_DIFF_TYPES] Cannot resolve "map_concat(map(foo, 1), NULL)" due to data type mismatch: The `map_concat` should all be of type map, but it's ["MAP<STRING, INT>", "VOID"].; line 1 pos 7;
'Project [unresolvedalias(map_concat(map(foo, 1), null), None)]
+- OneRowRelation
spark-sql (default)> select map_concat(map('foo', 1), cast(null as map<string, int>));
NULL
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liuyongvs commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on code in PR #3262:
URL: https://github.com/apache/calcite/pull/3262#discussion_r1241051720
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -5646,6 +5646,33 @@ private static void checkIf(SqlOperatorFixture f) {
+ "'SORT_ARRAY\\(<ARRAY>, <BOOLEAN>\\)'", false);
}
+ /** Tests {@code MAP_CONCAT} function from Spark. */
+ @Test void testMapConcatFunc() {
+ final SqlOperatorFixture f0 = fixture();
+ f0.setFor(SqlLibraryOperators.MAP_CONCAT);
+ f0.checkFails("^map_concat(map['foo', 1], map['bar', 2])^",
+ "No match found for function signature MAP_CONCAT\\("
+ + "<\\(CHAR\\(3\\), INTEGER\\) MAP>, <\\(CHAR\\(3\\), INTEGER\\) MAP>\\)", false);
+
+ final SqlOperatorFixture f = f0.withLibrary(SqlLibrary.SPARK);
+ f.checkScalar("map_concat(map['foo', 1], map['bar', 2])", "{foo=1, bar=2}",
+ "(CHAR(3) NOT NULL, INTEGER NOT NULL) MAP NOT NULL");
+ f.checkScalar("map_concat(map['foo', 1], map['bar', 2], map['foo', 2])", "{foo=2, bar=2}",
+ "(CHAR(3) NOT NULL, INTEGER NOT NULL) MAP NOT NULL");
+ f.checkScalar("map_concat(map[null, 1], map[null, 2])", "{null=2}",
+ "(NULL, INTEGER NOT NULL) MAP NOT NULL");
+ f.checkScalar("map_concat(map[1, 2], map[1, null])", "{1=null}",
+ "(INTEGER NOT NULL, INTEGER) MAP NOT NULL");
+ f.checkNull("map_concat(map['foo', 1], null)");
+ f.checkType("map_concat(map['foo', 1], null)", "(CHAR(3) NOT NULL, INTEGER NOT NULL) MAP");
+ f.checkNull("map_concat(null, map['foo', 1])");
+ f.checkType("map_concat(null, map['foo', 1])", "(CHAR(3) NOT NULL, INTEGER NOT NULL) MAP");
+ f.checkFails("^map_concat()^", INVALID_ARGUMENTS_NUMBER, false);
Review Comment:
@MasseGuillaume good catch! spark supports zero arg.
```
@transient override lazy val dataType: MapType = {
if (children.isEmpty) {
MapType(StringType, StringType)
} else {
super.dataType.asInstanceOf[MapType]
}
}
```
and i added the test
```
f.checkScalar("map_concat()", "{}",
"(VARCHAR NOT NULL, VARCHAR NOT NULL) MAP");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liuyongvs commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on code in PR #3262:
URL: https://github.com/apache/calcite/pull/3262#discussion_r1241051720
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -5646,6 +5646,33 @@ private static void checkIf(SqlOperatorFixture f) {
+ "'SORT_ARRAY\\(<ARRAY>, <BOOLEAN>\\)'", false);
}
+ /** Tests {@code MAP_CONCAT} function from Spark. */
+ @Test void testMapConcatFunc() {
+ final SqlOperatorFixture f0 = fixture();
+ f0.setFor(SqlLibraryOperators.MAP_CONCAT);
+ f0.checkFails("^map_concat(map['foo', 1], map['bar', 2])^",
+ "No match found for function signature MAP_CONCAT\\("
+ + "<\\(CHAR\\(3\\), INTEGER\\) MAP>, <\\(CHAR\\(3\\), INTEGER\\) MAP>\\)", false);
+
+ final SqlOperatorFixture f = f0.withLibrary(SqlLibrary.SPARK);
+ f.checkScalar("map_concat(map['foo', 1], map['bar', 2])", "{foo=1, bar=2}",
+ "(CHAR(3) NOT NULL, INTEGER NOT NULL) MAP NOT NULL");
+ f.checkScalar("map_concat(map['foo', 1], map['bar', 2], map['foo', 2])", "{foo=2, bar=2}",
+ "(CHAR(3) NOT NULL, INTEGER NOT NULL) MAP NOT NULL");
+ f.checkScalar("map_concat(map[null, 1], map[null, 2])", "{null=2}",
+ "(NULL, INTEGER NOT NULL) MAP NOT NULL");
+ f.checkScalar("map_concat(map[1, 2], map[1, null])", "{1=null}",
+ "(INTEGER NOT NULL, INTEGER) MAP NOT NULL");
+ f.checkNull("map_concat(map['foo', 1], null)");
+ f.checkType("map_concat(map['foo', 1], null)", "(CHAR(3) NOT NULL, INTEGER NOT NULL) MAP");
+ f.checkNull("map_concat(null, map['foo', 1])");
+ f.checkType("map_concat(null, map['foo', 1])", "(CHAR(3) NOT NULL, INTEGER NOT NULL) MAP");
+ f.checkFails("^map_concat()^", INVALID_ARGUMENTS_NUMBER, false);
Review Comment:
@MasseGuillaume good catch! spark supports zero arg.
```
@transient override lazy val dataType: MapType = {
if (children.isEmpty) {
MapType(StringType, StringType)
} else {
super.dataType.asInstanceOf[MapType]
}
}
```
and i added the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liuyongvs commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on code in PR #3262:
URL: https://github.com/apache/calcite/pull/3262#discussion_r1236606807
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3984,6 +3985,13 @@ public static List sortArray(List list, boolean ascending) {
return list;
}
+ /** Support the MAP_CONCAT function. */
+ public static Map mapConcat(Map... maps) {
+ final Map result = new LinkedHashMap();
+ Arrays.stream(maps).forEach(result::putAll);
Review Comment:
@zoudan i have a question, why lambda expressions has poor performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1605909632
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3262)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list) [97.4% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liuyongvs commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on code in PR #3262:
URL: https://github.com/apache/calcite/pull/3262#discussion_r1246002891
##########
site/_docs/reference.md:
##########
@@ -2740,9 +2740,11 @@ BigQuery's type system uses confusingly different names for types and functions:
| m | TO_BASE64(string) | Converts the *string* to base-64 encoded form and returns a encoded string
| b m | FROM_BASE64(string) | Returns the decoded result of a base-64 *string* as a string
| b o | LTRIM(string) | Returns *string* with all blanks removed from the start
+| s | MAP_CONCAT(map [, map]*) | Concatenates one or more maps. If any input argument is `NULL` the function returns `NULL`
Review Comment:
@MasseGuillaume add the comments for all the spark map constuct function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1612348883
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3262)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list) [97.4% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1588769987
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3262)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list) [96.8% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1589074850
hi @rubenada do you have time to review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1606765903
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3262)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list) [97.4% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1612337248
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3262)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list) [97.4% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1596418161
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3262)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list) [96.8% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1588877049
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3262)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list) [96.8% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1589012371
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3262)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list) [96.8% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1605927383
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3262)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3262&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3262&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list) [97.4% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3262&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] liuyongvs commented on pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …
Posted by "liuyongvs (via GitHub)" <gi...@apache.org>.
liuyongvs commented on PR #3262:
URL: https://github.com/apache/calcite/pull/3262#issuecomment-1612322434
rebase and squash the commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org