You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/04/12 13:02:32 UTC
[GitHub] [pulsar] codecov-commenter commented on pull request #20064: [improve][pulsar-shell] Use singleton custom command factories
codecov-commenter commented on PR #20064:
URL: https://github.com/apache/pulsar/pull/20064#issuecomment-1505238295
## [Codecov](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20064](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4587146) into [master](https://codecov.io/gh/apache/pulsar/commit/470b674016c8718f2dfd0a0f93cf02d49af0fead?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (470b674) will **increase** coverage by `39.80%`.
> The diff coverage is `73.10%`.
[](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #20064 +/- ##
=============================================
+ Coverage 33.13% 72.93% +39.80%
+ Complexity 12164 3683 -8481
=============================================
Files 1497 1865 +368
Lines 114032 138100 +24068
Branches 12373 15179 +2806
=============================================
+ Hits 37782 100722 +62940
+ Misses 71340 29372 -41968
- Partials 4910 8006 +3096
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.11% <5.65%> (?)` | |
| systests | `24.92% <3.66%> (?)` | |
| unittests | `72.20% <73.10%> (+39.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/bookkeeper/mledger/LedgerOffloaderFactory.java](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9MZWRnZXJPZmZsb2FkZXJGYWN0b3J5LmphdmE=) | `50.00% <0.00%> (+50.00%)` | :arrow_up: |
| [...ain/java/org/apache/pulsar/broker/rest/Topics.java](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9yZXN0L1RvcGljcy5qYXZh) | `100.00% <ø> (+100.00%)` | :arrow_up: |
| [...a/org/apache/pulsar/broker/service/Dispatcher.java](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0Rpc3BhdGNoZXIuamF2YQ==) | `35.71% <ø> (+7.14%)` | :arrow_up: |
| [...a/org/apache/pulsar/broker/service/Replicator.java](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1JlcGxpY2F0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...lsar/broker/service/StickyKeyConsumerSelector.java](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1N0aWNreUtleUNvbnN1bWVyU2VsZWN0b3IuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...n/java/org/apache/pulsar/broker/service/Topic.java](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1RvcGljLmphdmE=) | `31.81% <ø> (+22.72%)` | :arrow_up: |
| [...service/nonpersistent/NonPersistentReplicator.java](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL25vbnBlcnNpc3RlbnQvTm9uUGVyc2lzdGVudFJlcGxpY2F0b3IuamF2YQ==) | `63.36% <ø> (+63.36%)` | :arrow_up: |
| [...ker/stats/prometheus/metrics/LongAdderCounter.java](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9wcm9tZXRoZXVzL21ldHJpY3MvTG9uZ0FkZGVyQ291bnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...lsar/sql/presto/PulsarConnectorMetricsTracker.java](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLXNxbC9wcmVzdG8tcHVsc2FyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvc3FsL3ByZXN0by9QdWxzYXJDb25uZWN0b3JNZXRyaWNzVHJhY2tlci5qYXZh) | `30.82% <0.00%> (ø)` | |
| [...d/filesystem/FileSystemLedgerOffloaderFactory.java](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGllcmVkLXN0b3JhZ2UvZmlsZS1zeXN0ZW0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9vZmZsb2FkL2ZpbGVzeXN0ZW0vRmlsZVN5c3RlbUxlZGdlck9mZmxvYWRlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/pulsar/pull/20064?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [1498 files with indirect coverage changes](https://codecov.io/gh/apache/pulsar/pull/20064/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org