You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by je...@apache.org on 2001/10/05 10:51:43 UTC
cvs commit: httpd-2.0/server protocol.c
jerenkrantz 01/10/05 01:51:43
Modified: server protocol.c
Log:
I believe it is a kosher for a filter to return EOS, but return APR_SUCCESS
via ap_get_brigade. So, we should treat this as end-of-input.
Revision Changes Path
1.48 +4 -0 httpd-2.0/server/protocol.c
Index: protocol.c
===================================================================
RCS file: /home/cvs/httpd-2.0/server/protocol.c,v
retrieving revision 1.47
retrieving revision 1.48
diff -u -r1.47 -r1.48
--- protocol.c 2001/09/29 08:48:59 1.47
+++ protocol.c 2001/10/05 08:51:43 1.48
@@ -227,6 +227,10 @@
}
}
e = APR_BRIGADE_FIRST(b);
+ if (APR_BUCKET_IS_EOS(e)) {
+ apr_brigade_destroy(b);
+ return -1;
+ }
if (e->length == 0) {
apr_bucket_delete(e);
continue;
Re: cvs commit: httpd-2.0/server protocol.c
Posted by Ryan Bloom <rb...@covalent.net>.
On Friday 05 October 2001 01:51 am, jerenkrantz@apache.org wrote:
> jerenkrantz 01/10/05 01:51:43
>
> Modified: server protocol.c
> Log:
> I believe it is a kosher for a filter to return EOS, but return
> APR_SUCCESS via ap_get_brigade. So, we should treat this as end-of-input.
It is perfectly correct for a filter to return an EOS bucket and APR_SUCCESS. Also,
-1 is not an error code for us, nor should it be.
Ryan
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------
Re: cvs commit: httpd-2.0/server protocol.c
Posted by Ryan Bloom <rb...@covalent.net>.
> I believe it is a kosher for a filter to return EOS, but return
> APR_SUCCESS via ap_get_brigade. So, we should treat this as end-of-input.
BTW, kosher is an adjective, not a noun. :-)
Ryan
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------
Re: cvs commit: httpd-2.0/server protocol.c
Posted by Ryan Bloom <rb...@covalent.net>.
> I believe it is a kosher for a filter to return EOS, but return
> APR_SUCCESS via ap_get_brigade. So, we should treat this as end-of-input.
BTW, kosher is an adjective, not a noun. :-)
Ryan
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------
Re: cvs commit: httpd-2.0/server protocol.c
Posted by Ryan Bloom <rb...@covalent.net>.
On Friday 05 October 2001 01:51 am, jerenkrantz@apache.org wrote:
> jerenkrantz 01/10/05 01:51:43
>
> Modified: server protocol.c
> Log:
> I believe it is a kosher for a filter to return EOS, but return
> APR_SUCCESS via ap_get_brigade. So, we should treat this as end-of-input.
It is perfectly correct for a filter to return an EOS bucket and APR_SUCCESS. Also,
-1 is not an error code for us, nor should it be.
Ryan
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------