You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/07/19 21:20:53 UTC

[GitHub] [beam] lostluck opened a new issue, #27567: [Task][Go SDK][Cleanup]: Migrate passert package exclusively to the generic register package.

lostluck opened a new issue, #27567:
URL: https://github.com/apache/beam/issues/27567

   ### What needs to happen?
   
   The go generate lines would need to be removed:
   https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/testing/passert/passert.go#L31
   
   and the registrations in `passert.shims.go` https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/testing/passert/passert.shims.go should be moved to `init()` blocks using the register package instead.
   
   Partially done in #27565, this will be easier to work on once prism is the default runner, since the error unregistered portions will be provided as test failures. See #24789
   
   ### Issue Priority
   
   Priority: 3 (nice-to-have improvement)
   
   ### Issue Components
   
   - [ ] Component: Python SDK
   - [ ] Component: Java SDK
   - [X] Component: Go SDK
   - [ ] Component: Typescript SDK
   - [ ] Component: IO connector
   - [ ] Component: Beam examples
   - [ ] Component: Beam playground
   - [ ] Component: Beam katas
   - [ ] Component: Website
   - [ ] Component: Spark Runner
   - [ ] Component: Flink Runner
   - [ ] Component: Samza Runner
   - [ ] Component: Twister2 Runner
   - [ ] Component: Hazelcast Jet Runner
   - [ ] Component: Google Cloud Dataflow Runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task][Go SDK][Cleanup]: Migrate passert package exclusively to the generic register package. [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27567:
URL: https://github.com/apache/beam/issues/27567#issuecomment-5468741036

   This issue has been marked as stale due to 150 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that’s incorrect or this issue still needs to be addressed, please simply write any comment. If closed, you can reopen the issue at any time. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task][Go SDK][Cleanup]: Migrate passert package exclusively to the generic register package. [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #27567: [Task][Go SDK][Cleanup]: Migrate passert package exclusively to the generic register package.
URL: https://github.com/apache/beam/issues/27567


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task][Go SDK][Cleanup]: Migrate passert package exclusively to the generic register package. [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27567:
URL: https://github.com/apache/beam/issues/27567#issuecomment-5911718849

   This issue has been closed due to lack of activity. If you think that is incorrect, you can reopen the issue at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org