You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/18 05:29:09 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1505:
Modify common queue TaskQueueZKImplTest.java unit test
codecov-io commented on issue #1505: Modify common queue TaskQueueZKImplTest.java unit test
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1505#issuecomment-566873994
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1505?src=pr&el=h1) Report
> Merging [#1505](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1505?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/c2f4b65a86d9d4886cce27786dbbbf8fe071dfa8?src=pr&el=desc) will **increase** coverage by `1.16%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1505?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1505 +/- ##
========================================
+ Coverage 5.59% 6.75% +1.16%
========================================
Files 272 272
Lines 13613 13612 -1
Branches 2165 2165
========================================
+ Hits 762 920 +158
+ Misses 12806 12628 -178
- Partials 45 64 +19
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1505?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dolphinscheduler/common/queue/TaskQueueZkImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1505/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3F1ZXVlL1Rhc2tRdWV1ZVprSW1wbC5qYXZh) | `71.6% <ø> (+71.6%)` | :arrow_up: |
| [.../apache/dolphinscheduler/common/utils/OSUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1505/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL09TVXRpbHMuamF2YQ==) | `13.44% <0%> (+0.84%)` | :arrow_up: |
| [...rg/apache/dolphinscheduler/common/utils/Bytes.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1505/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0J5dGVzLmphdmE=) | `1.88% <0%> (+1.88%)` | :arrow_up: |
| [...che/dolphinscheduler/common/utils/CommonUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1505/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0NvbW1vblV0aWxzLmphdmE=) | `10.52% <0%> (+10.52%)` | :arrow_up: |
| [...e/dolphinscheduler/common/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1505/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL0Fic3RyYWN0WktDbGllbnQuamF2YQ==) | `15.23% <0%> (+15.23%)` | :arrow_up: |
| [...olphinscheduler/common/queue/TaskQueueFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1505/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3F1ZXVlL1Rhc2tRdWV1ZUZhY3RvcnkuamF2YQ==) | `50% <0%> (+50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1505?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1505?src=pr&el=footer). Last update [c2f4b65...deb215e](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1505?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services