You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/07/10 09:37:02 UTC
Review Request 12437: Updated Mesos to use the new os::killtree.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12437/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/launcher/executor.cpp 2907ec59d01fae2249a92c2a84cf49cd5fb9a666
src/slave/process_isolator.cpp 4b65b35ce96bda1b5e0748148577886d067e59a0
Diff: https://reviews.apache.org/r/12437/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 12437: Updated Mesos to use the new os::killtree.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12437/#review24570
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 10, 2013, 7:37 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12437/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 7:37 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 2907ec59d01fae2249a92c2a84cf49cd5fb9a666
> src/slave/process_isolator.cpp 4b65b35ce96bda1b5e0748148577886d067e59a0
>
> Diff: https://reviews.apache.org/r/12437/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 12437: Updated Mesos to use the new os::killtree.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12437/#review24000
-----------------------------------------------------------
This will need a rebase on Vinod's change to libprocess-ify the Command Executor.
src/slave/process_isolator.cpp
<https://reviews.apache.org/r/12437/#comment47819>
This bit makes me think most users of killtree will be worried about the parent pid being gone, should we therefore make os::killtree still work when the parent pid is missing but (groups || sessions) == true?
- Ben Mahler
On July 10, 2013, 7:37 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12437/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 7:37 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 2907ec59d01fae2249a92c2a84cf49cd5fb9a666
> src/slave/process_isolator.cpp 4b65b35ce96bda1b5e0748148577886d067e59a0
>
> Diff: https://reviews.apache.org/r/12437/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>