You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Karuppayya <gi...@git.apache.org> on 2015/09/15 18:43:34 UTC

[GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

GitHub user Karuppayya opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/308

    Interpreter setting not getting saved

    Scenario.
    In the create new interpreter setting form
    1)Press "+" to create a new key/value.
    2) Enter details.(dont press "+" button)
    3)Press "save" button
    The interpreter setting doesnot have the property, and is not persisted.
    
    Only when the "+" is pressed(or is there any other way), the setting is saved.
    This is true for settings edit form as well.
    
    Fixing this 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Karuppayya/incubator-zeppelin settings_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #308
    
----
commit 2868f28de586bbda67765e3bc4be2221b212d88c
Author: Karup <ka...@outlook.com>
Date:   2015-09-15T16:22:44Z

    Setting not getting saved

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/308#issuecomment-140600751
  
    @felixcheung I guess the user would expect all entered properties to get persisted when he clicks "Save".  Clicking "Save"  with incomplete values seems to be more of a user error.  Also,  the user still has an option to edit them. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/308#issuecomment-141660225
  
    Based on aboove discussion, seems to be hampering User Experience . Hence closing this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/308#issuecomment-140585375
  
    Thanks for looking into this. I myself have also bitten by this issue.
    Is this the right user experience though, storing something that is potentially "imcomplete" ie. the user hasn't click '+' yet?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/308


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

Posted by IT CTO <go...@gmail.com>.
I agree with corneadoug, if we automatically persist the properties when
user press save without pressing the + sigh then we have to add some kind
of cancel only on the preperty level.
say I just typed in a property name and value and did not press +, how do I
cancel this without saving?

maybe a dirty flag can be added and a warning when we press save without
saving the property value first?
Eran

On Wed, Sep 16, 2015 at 10:33 AM corneadoug <gi...@git.apache.org> wrote:

> Github user corneadoug commented on the pull request:
>
>
> https://github.com/apache/incubator-zeppelin/pull/308#issuecomment-140655687
>
>     I think that behavior (not saving what is in the form) is okay.
>     However, properties that were added should not be shown with an input,
> otherwise it's confusing.
>     ![screen shot 2015-09-16 at 4 32 14 pm](
> https://cloud.githubusercontent.com/assets/710411/9898827/94bdd54a-5c90-11e5-926d-49642702825e.png
> )
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
-- 
Eran | "You don't need eyes to see, you need vision" (Faithless)

[GitHub] incubator-zeppelin pull request: Interpreter setting not getting s...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/308#issuecomment-140655687
  
    I think that behavior (not saving what is in the form) is okay.
    However, properties that were added should not be shown with an input, otherwise it's confusing.
    ![screen shot 2015-09-16 at 4 32 14 pm](https://cloud.githubusercontent.com/assets/710411/9898827/94bdd54a-5c90-11e5-926d-49642702825e.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---