You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "dharanad (via GitHub)" <gi...@apache.org> on 2024/07/18 11:28:54 UTC

[I] chroe: Add `SessionState` to `MockContextProvider` just like `SessionContextProvider` [datafusion]

dharanad opened a new issue, #11531:
URL: https://github.com/apache/datafusion/issues/11531

   ### Is your feature request related to a problem or challenge?
   
                 I prefer not to re-introduce `with_expr_planner` back for context provider.
   
   It is better to use session state in context, and add planner into session state.
   
   Similar to SessionContextProvider
   ```rust
   struct SessionContextProvider<'a> {
       state: &'a SessionState,
       ...
   }
   ```
   
   _Originally posted by @jayzhan211 in https://github.com/apache/datafusion/pull/11487#discussion_r1682349054_
               
   This is cleanup task to remove functions like `with_udaf` `with_expr_planner` from `MockContextProvider` and make it consistent with public interfaces. We need to update all the testcases which are affected by this change.
   
   
   ### Describe the solution you'd like
   
   _No response_
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] chroe: Add `SessionState` to `MockContextProvider` just like `SessionContextProvider` [datafusion]

Posted by "dharanad (via GitHub)" <gi...@apache.org>.
dharanad commented on issue #11531:
URL: https://github.com/apache/datafusion/issues/11531#issuecomment-2236340646

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] chore: Add `SessionState` to `MockContextProvider` just like `SessionContextProvider` [datafusion]

Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 closed issue #11531: chore: Add `SessionState` to `MockContextProvider` just like `SessionContextProvider`
URL: https://github.com/apache/datafusion/issues/11531


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org