You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/05 23:30:01 UTC

[jira] [Commented] (ARROW-1770) [GLib] Fix GLib compiler warning

    [ https://issues.apache.org/jira/browse/ARROW-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239766#comment-16239766 ] 

ASF GitHub Bot commented on ARROW-1770:
---------------------------------------

wesm closed pull request #1287: ARROW-1770: [GLib] Fix GLib compiler warning
URL: https://github.com/apache/arrow/pull/1287
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/c_glib/arrow-glib/input-stream.cpp b/c_glib/arrow-glib/input-stream.cpp
index d628baeee..a7a894b9d 100644
--- a/c_glib/arrow-glib/input-stream.cpp
+++ b/c_glib/arrow-glib/input-stream.cpp
@@ -437,13 +437,13 @@ namespace garrow {
     }
 
     arrow::Status ReadAt(int64_t position, int64_t n_bytes,
-			 int64_t *n_read_bytes, uint8_t* out) {
+			 int64_t *n_read_bytes, uint8_t* out) override {
 	return arrow::io::RandomAccessFile::ReadAt(
 	    position, n_bytes, n_read_bytes, out);
     }
 
     arrow::Status ReadAt(int64_t position, int64_t n_bytes,
-			 std::shared_ptr<arrow::Buffer>* out) {
+			 std::shared_ptr<arrow::Buffer>* out) override {
 	return arrow::io::RandomAccessFile::ReadAt(position, n_bytes, out);
     }
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [GLib] Fix GLib compiler warning
> --------------------------------
>
>                 Key: ARROW-1770
>                 URL: https://issues.apache.org/jira/browse/ARROW-1770
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: GLib
>    Affects Versions: 0.7.1
>            Reporter: Phillip Cloud
>            Assignee: Phillip Cloud
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 0.8.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)