You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kk...@apache.org on 2012/12/05 06:34:18 UTC
svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config: ajp.xml
executor.xml http.xml
Author: kkolinko
Date: Wed Dec 5 05:34:16 2012
New Revision: 1417282
URL: http://svn.apache.org/viewvc?rev=1417282&view=rev
Log:
Clarify the docs that the thread priority value is a number and not some weird string value.
A thread on users@ from Dec 02 2012:
http://tomcat.markmail.org/thread/iud2m7j743qwx4ui
Modified:
tomcat/trunk/webapps/docs/config/ajp.xml
tomcat/trunk/webapps/docs/config/executor.xml
tomcat/trunk/webapps/docs/config/http.xml
Modified: tomcat/trunk/webapps/docs/config/ajp.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/ajp.xml?rev=1417282&r1=1417281&r2=1417282&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/config/ajp.xml (original)
+++ tomcat/trunk/webapps/docs/config/ajp.xml Wed Dec 5 05:34:16 2012
@@ -285,9 +285,10 @@
<attribute name="acceptorThreadPriority" required="false">
<p>The priority of the acceptor threads. The threads used to accept
- new connections. The default value is
- <code>java.lang.Thread#NORM_PRIORITY</code>. See the JavaDoc for the
- java.lang.Thread class for more details on what this priority means.</p>
+ new connections. The default value is <code>5</code> (the value of the
+ <code>java.lang.Thread.NORM_PRIORITY</code> constant). See the JavaDoc
+ for the <code>java.lang.Thread</code> class for more details on what
+ this priority means.</p>
</attribute>
<attribute name="address" required="false">
@@ -411,9 +412,10 @@
<attribute name="threadPriority" required="false">
<p>The priority of the request processing threads within the JVM.
- The default value is <code>java.lang.Thread#NORM_PRIORITY</code>.
- See the JavaDoc for the java.lang.Thread class for more details on
- what this priority means.
+ The default value is <code>5</code> (the value of the
+ <code>java.lang.Thread.NORM_PRIORITY</code> constant). See the JavaDoc
+ for the <code>java.lang.Thread</code> class for more details on what
+ this priority means.
</p>
</attribute>
Modified: tomcat/trunk/webapps/docs/config/executor.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/executor.xml?rev=1417282&r1=1417281&r2=1417282&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/config/executor.xml (original)
+++ tomcat/trunk/webapps/docs/config/executor.xml Wed Dec 5 05:34:16 2012
@@ -83,7 +83,8 @@
<attributes>
<attribute name="threadPriority" required="false">
- <p>(int) The thread priority for threads in the executor, the default is <code>Thread.NORM_PRIORITY</code></p>
+ <p>(int) The thread priority for threads in the executor, the default is
+ <code>5</code> (the value of the <code>Thread.NORM_PRIORITY</code> constant)</p>
</attribute>
<attribute name="daemon" required="false">
<p>(boolean) Whether the threads should be daemon threads or not, the default is <code>true</code></p>
Modified: tomcat/trunk/webapps/docs/config/http.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/http.xml?rev=1417282&r1=1417281&r2=1417282&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/config/http.xml (original)
+++ tomcat/trunk/webapps/docs/config/http.xml Wed Dec 5 05:34:16 2012
@@ -279,9 +279,10 @@
<attribute name="acceptorThreadPriority" required="false">
<p>The priority of the acceptor threads. The threads used to accept
- new connections. The default value is
- <code>java.lang.Thread#NORM_PRIORITY</code>. See the JavaDoc for the
- java.lang.Thread class for more details on what this priority means.</p>
+ new connections. The default value is <code>5</code> (the value of the
+ <code>java.lang.Thread.NORM_PRIORITY</code> constant). See the JavaDoc
+ for the <code>java.lang.Thread</code> class for more details on what
+ this priority means.</p>
</attribute>
<attribute name="address" required="false">
@@ -497,9 +498,10 @@
<attribute name="threadPriority" required="false">
<p>The priority of the request processing threads within the JVM.
- The default value is <code>java.lang.Thread#NORM_PRIORITY</code>.
- See the JavaDoc for the java.lang.Thread class for more details on
- what this priority means.
+ The default value is <code>5</code> (the value of the
+ <code>java.lang.Thread.NORM_PRIORITY</code> constant). See the JavaDoc
+ for the <code>java.lang.Thread</code> class for more details on what
+ this priority means.
</p>
</attribute>
@@ -621,9 +623,11 @@
</attribute>
<attribute name="pollerThreadPriority" required="false">
- <p>(int)The priority of the poller threads. The default value is
- <code>java.lang.Thread#NORM_PRIORITY</code>. See the JavaDoc for the
- java.lang.Thread class for more details on what this priority means.</p>
+ <p>(int)The priority of the poller threads.
+ The default value is <code>5</code> (the value of the
+ <code>java.lang.Thread.NORM_PRIORITY</code> constant). See the JavaDoc
+ for the <code>java.lang.Thread</code> class for more details on what
+ this priority means.</p>
</attribute>
<attribute name="selectorTimeout" required="false">
@@ -807,10 +811,11 @@
</attribute>
<attribute name="threadPriority" required="false">
- <p>(int)The priority of the acceptor and poller threads. The default
- value is <code>java.lang.Thread#NORM_PRIORITY</code>. See the JavaDoc
- for the java.lang.Thread class for more details on what this priority
- means.</p>
+ <p>(int)The priority of the acceptor and poller threads.
+ The default value is <code>5</code> (the value of the
+ <code>java.lang.Thread.NORM_PRIORITY</code> constant). See the JavaDoc
+ for the <code>java.lang.Thread</code> class for more details on what
+ this priority means.</p>
</attribute>
<attribute name="useComet" required="false">
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
RE: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config:
ajp.xml executor.xml http.xml
Posted by "Caldarale, Charles R" <Ch...@unisys.com>.
> From: Christopher Schultz [mailto:chris@christopherschultz.net]
> Subject: Re: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config: ajp.xml executor.xml http.xml
> > The value of NORM_PRIORITY on Windows 64-bit JDK 7 appears to be 1,
> > not 5. I haven't checked other versions or platforms.
> This is part of the public java.util.Thread API. If those values change,
> bad things likely happen.
Probably not, but regardless, I had a typo in my program that displayed the values, hence my erroneous statement.
- Chuck
THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY MATERIAL and is thus for use only by the intended recipient. If you received this in error, please contact the sender and delete the e-mail and its attachments from all computers.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config:
ajp.xml executor.xml http.xml
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Konstantin,
On 12/5/12 3:06 AM, Konstantin Kolinko wrote:
> 2012/12/5 Caldarale, Charles R <Ch...@unisys.com>:
>>> From: kkolinko@apache.org [mailto:kkolinko@apache.org]
>>> Subject: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config: ajp.xml executor.xml http.xml
>>
>>> Author: kkolinko
>>> Date: Wed Dec 5 05:34:16 2012
>>> New Revision: 1417282
>>
>>> Modified: tomcat/trunk/webapps/docs/config/ajp.xml
>>> URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/ajp.xml?
>>> rev=1417282&r1=1417281&r2=1417282&view=diff
>>> ==============================================================================
>>> --- tomcat/trunk/webapps/docs/config/ajp.xml (original)
>>> +++ tomcat/trunk/webapps/docs/config/ajp.xml Wed Dec 5 05:34:16 2012
>>> @@ -285,9 +285,10 @@
>>>
>>> <attribute name="acceptorThreadPriority" required="false">
>>> <p>The priority of the acceptor threads. The threads used to accept
>>> - new connections. The default value is
>>> - <code>java.lang.Thread#NORM_PRIORITY</code>. See the JavaDoc for the
>>> - java.lang.Thread class for more details on what this priority means.</p>
>>> + new connections. The default value is <code>5</code> (the value of the
>>
>> The value of NORM_PRIORITY on Windows 64-bit JDK 7 appears to be 1, not 5. I haven't checked other versions or platforms.
>
> 1 is MIN_PRIORITY.
>
> The constants are evaluated at compile time. They cannot be different
> between systems.
+1
This is part of the public java.util.Thread API. If those values change,
bad things likely happen.
From my Oracle Java 1.7 distro on 64-bit Mac OS:
/**
* The minimum priority that a thread can have.
*/
public final static int MIN_PRIORITY = 1;
/**
* The default priority that is assigned to a thread.
*/
public final static int NORM_PRIORITY = 5;
/**
* The maximum priority that a thread can have.
*/
public final static int MAX_PRIORITY = 10;
-chris
Re: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config:
ajp.xml executor.xml http.xml
Posted by Konstantin Kolinko <kn...@gmail.com>.
2012/12/5 Caldarale, Charles R <Ch...@unisys.com>:
>> From: kkolinko@apache.org [mailto:kkolinko@apache.org]
>> Subject: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config: ajp.xml executor.xml http.xml
>
>> Author: kkolinko
>> Date: Wed Dec 5 05:34:16 2012
>> New Revision: 1417282
>
>> Modified: tomcat/trunk/webapps/docs/config/ajp.xml
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/ajp.xml?
>> rev=1417282&r1=1417281&r2=1417282&view=diff
>> ==============================================================================
>> --- tomcat/trunk/webapps/docs/config/ajp.xml (original)
>> +++ tomcat/trunk/webapps/docs/config/ajp.xml Wed Dec 5 05:34:16 2012
>> @@ -285,9 +285,10 @@
>>
>> <attribute name="acceptorThreadPriority" required="false">
>> <p>The priority of the acceptor threads. The threads used to accept
>> - new connections. The default value is
>> - <code>java.lang.Thread#NORM_PRIORITY</code>. See the JavaDoc for the
>> - java.lang.Thread class for more details on what this priority means.</p>
>> + new connections. The default value is <code>5</code> (the value of the
>
> The value of NORM_PRIORITY on Windows 64-bit JDK 7 appears to be 1, not 5. I haven't checked other versions or platforms.
1 is MIN_PRIORITY.
The constants are evaluated at compile time. They cannot be different
between systems.
(Whether all the values 1..10 provide different priorities, or they
are mapped to the same os-level priority is a different matter).
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
RE: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config:
ajp.xml executor.xml http.xml
Posted by "Caldarale, Charles R" <Ch...@unisys.com>.
> From: kkolinko@apache.org [mailto:kkolinko@apache.org]
> Subject: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config: ajp.xml executor.xml http.xml
> Author: kkolinko
> Date: Wed Dec 5 05:34:16 2012
> New Revision: 1417282
> Modified: tomcat/trunk/webapps/docs/config/ajp.xml
> URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/ajp.xml?
> rev=1417282&r1=1417281&r2=1417282&view=diff
> ==============================================================================
> --- tomcat/trunk/webapps/docs/config/ajp.xml (original)
> +++ tomcat/trunk/webapps/docs/config/ajp.xml Wed Dec 5 05:34:16 2012
> @@ -285,9 +285,10 @@
>
> <attribute name="acceptorThreadPriority" required="false">
> <p>The priority of the acceptor threads. The threads used to accept
> - new connections. The default value is
> - <code>java.lang.Thread#NORM_PRIORITY</code>. See the JavaDoc for the
> - java.lang.Thread class for more details on what this priority means.</p>
> + new connections. The default value is <code>5</code> (the value of the
The value of NORM_PRIORITY on Windows 64-bit JDK 7 appears to be 1, not 5. I haven't checked other versions or platforms.
- Chuck
THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY MATERIAL and is thus for use only by the intended recipient. If you received this in error, please contact the sender and delete the e-mail and its attachments from all computers.