You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2025/04/30 16:11:35 UTC

Re: [PR] AIP-82: Add KafkaMessageQueueProvider [airflow]

potiuk commented on code in PR #49938:
URL: https://github.com/apache/airflow/pull/49938#discussion_r2069008941


##########
providers/common/messaging/src/airflow/providers/common/messaging/providers/kafka.py:
##########
@@ -0,0 +1,94 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   Hmm. I have some doubts.. I already had it already but this one actually makes it more visible.
   
   Why are we adding the `common.messaging` implementation to common.messaging? 
   
   They shoud be in "Amazon" (sqs) and `Kafka` provider (kafka`) - NOT in common.messaging I think.
   
   Similarly to common.sql - where implementation of teh DBAPIHook is in the respective provider.
   
   OR am I wrong ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org