You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/12/23 14:54:44 UTC

[GitHub] [iceberg] izchen opened a new pull request #3799: Hotfix: Attach Test annotation to testDeleteFromTableAtSnapshot

izchen opened a new pull request #3799:
URL: https://github.com/apache/iceberg/pull/3799


   When I cherry-pick, I found that the method testDeleteFromTableAtSnapshot is missing a Test annotation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #3799: Hotfix: Attach Test annotation to testDeleteFromTableAtSnapshot

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3799:
URL: https://github.com/apache/iceberg/pull/3799#issuecomment-1002781570


   Enjoy your vacation! We'll have to track this down, but I don't think there's a rush.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] wypoon commented on pull request #3799: Hotfix: Attach Test annotation to testDeleteFromTableAtSnapshot

Posted by GitBox <gi...@apache.org>.
wypoon commented on pull request #3799:
URL: https://github.com/apache/iceberg/pull/3799#issuecomment-1002773223


   Hmm, looks like an oversight on my part when porting the change to v3.0. It should have the `@Test` annotation. However, I am on vacation, don't have my work machine at hand, and not able to test it at the moment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] izchen commented on pull request #3799: Hotfix: Attach Test annotation to testDeleteFromTableAtSnapshot

Posted by GitBox <gi...@apache.org>.
izchen commented on pull request #3799:
URL: https://github.com/apache/iceberg/pull/3799#issuecomment-1004649636


   I submitted a PR to fix this: https://github.com/apache/iceberg/pull/3840


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #3799: Hotfix: Attach Test annotation to testDeleteFromTableAtSnapshot

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3799:
URL: https://github.com/apache/iceberg/pull/3799#issuecomment-1002763536


   @izchen, why did you close this? It looks like this test should be running. @wypoon, any idea why this tests was disabled?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] izchen commented on pull request #3799: Hotfix: Attach Test annotation to testDeleteFromTableAtSnapshot

Posted by GitBox <gi...@apache.org>.
izchen commented on pull request #3799:
URL: https://github.com/apache/iceberg/pull/3799#issuecomment-1004600677


   > Why did you close this? It looks like this test should be running.
   
   @rdblue, this UT failed in spark version 3.0. I think this is because the [[SPARK-33623][SQL] Add canDeleteWhere to SupportsDelete](https://github.com/apache/spark/pull/30562) does not exist in 3.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] wypoon commented on pull request #3799: Hotfix: Attach Test annotation to testDeleteFromTableAtSnapshot

Posted by GitBox <gi...@apache.org>.
wypoon commented on pull request #3799:
URL: https://github.com/apache/iceberg/pull/3799#issuecomment-1005124840


   @izchen thanks for the explanation. I'd forgotten about the fact that `canDeleteWhere` was added to `SupportsDelete` only in Spark 3.1 and is not present in Spark 3.0. The fact that we didn't try to clean up all such differences when we reorganized the Spark support into separate directories tripped me up. I think I inadvertently omitted the `@Test` annotation for the new test and didn't mean to disable it, but this omission led to the CI passing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] izchen closed pull request #3799: Hotfix: Attach Test annotation to testDeleteFromTableAtSnapshot

Posted by GitBox <gi...@apache.org>.
izchen closed pull request #3799:
URL: https://github.com/apache/iceberg/pull/3799


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org