You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/10/03 19:49:27 UTC
Re: Review Request 36816: Support HTTP checks in Mesos health check
program
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/
-----------------------------------------------------------
(Updated Oct. 3, 2015, 5:49 p.m.)
Review request for mesos, Adam B, Michael Park, and Timothy Chen.
Changes
-------
Rebase
Bugs: MESOS-2533
https://issues.apache.org/jira/browse/MESOS-2533
Repository: mesos
Description
-------
Support HTTP checks in Mesos health check program
Diffs (updated)
-----
include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999
src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade
src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9
src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade
Diff: https://reviews.apache.org/r/36816/diff/
Testing
-------
* Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp
make check
Thanks,
haosdent huang
Re: Review Request 36816: Support HTTP checks in Mesos health check
program
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review106892
-----------------------------------------------------------
src/health-check/main.cpp (line 238)
<https://reviews.apache.org/r/36816/#comment165698>
Seems weird to perform a http check with not statuses to check. Instead of returning silently I think we should send an error instead since the user might as well don't perform this check right?
src/health-check/main.cpp (line 243)
<https://reviews.apache.org/r/36816/#comment165696>
Please log VLOG(2) the http url we're trying to health check
src/health-check/main.cpp (line 263)
<https://reviews.apache.org/r/36816/#comment165697>
Response should also have a code uint32_t field now, you can check that directly without checking strings.
src/health-check/main.cpp (line 295)
<https://reviews.apache.org/r/36816/#comment165695>
This formatting problem somehow slipped in, we need to align the << in both lines.
src/tests/health_check_tests.cpp (line 930)
<https://reviews.apache.org/r/36816/#comment165699>
Can you also test that it fails the health check correctly when status doesn't match?
- Timothy Chen
On Oct. 3, 2015, 6:01 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36816/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 6:01 p.m.)
>
>
> Review request for mesos, Adam B, Michael Park, and Timothy Chen.
>
>
> Bugs: MESOS-2533
> https://issues.apache.org/jira/browse/MESOS-2533
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Support HTTP checks in Mesos health check program
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999
> src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade
> src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9
> src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade
>
> Diff: https://reviews.apache.org/r/36816/diff/
>
>
> Testing
> -------
>
> * Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 36816: Support HTTP checks in Mesos health check
program
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review101426
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36816]
All tests passed.
- Mesos ReviewBot
On Oct. 3, 2015, 6:01 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36816/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 6:01 p.m.)
>
>
> Review request for mesos, Adam B, Michael Park, and Timothy Chen.
>
>
> Bugs: MESOS-2533
> https://issues.apache.org/jira/browse/MESOS-2533
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Support HTTP checks in Mesos health check program
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999
> src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade
> src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9
> src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade
>
> Diff: https://reviews.apache.org/r/36816/diff/
>
>
> Testing
> -------
>
> * Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 36816: Supported HTTP in Mesos health check
program.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/
-----------------------------------------------------------
(Updated April 17, 2016, 9:14 a.m.)
Review request for mesos, Adam B, Michael Park, and Timothy Chen.
Changes
-------
Rebase.
Summary (updated)
-----------------
Supported HTTP in Mesos health check program.
Bugs: MESOS-2533
https://issues.apache.org/jira/browse/MESOS-2533
Repository: mesos
Description (updated)
-------
Supported HTTP in Mesos health check program.
Diffs (updated)
-----
include/mesos/mesos.proto 87af4a06db8cc3889fe4d3b314206103f5ce5f2d
include/mesos/v1/mesos.proto 34da0a1484dc2f71262d8b97484b8edaae35bb6c
src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7
src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999
src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb
Diff: https://reviews.apache.org/r/36816/diff/
Testing
-------
* Add unit test cases: HealthCheckTest.HealthyTaskThroughHttp and HealthCheckTest.HealthyTaskNotMatchHttpStatuses
make check
Thanks,
haosdent huang
Re: Review Request 36816: Support HTTP checks in Mesos health check
program
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review110144
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36816]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 12, 2015, 4:08 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36816/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 4:08 p.m.)
>
>
> Review request for mesos, Adam B, Michael Park, and Timothy Chen.
>
>
> Bugs: MESOS-2533
> https://issues.apache.org/jira/browse/MESOS-2533
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Support HTTP checks in Mesos health check program
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77
> src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2
> src/health-check/main.cpp 0beaed575ec865d81e6e3d83d8a0c894613acba4
> src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
>
> Diff: https://reviews.apache.org/r/36816/diff/
>
>
> Testing
> -------
>
> * Add unit test cases: HealthCheckTest.HealthyTaskThroughHttp and HealthCheckTest.HealthyTaskNotMatchHttpStatuses
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 36816: Support HTTP checks in Mesos health check
program
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/
-----------------------------------------------------------
(Updated Dec. 12, 2015, 4:08 p.m.)
Review request for mesos, Adam B, Michael Park, and Timothy Chen.
Bugs: MESOS-2533
https://issues.apache.org/jira/browse/MESOS-2533
Repository: mesos
Description
-------
Support HTTP checks in Mesos health check program
Diffs
-----
include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77
src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2
src/health-check/main.cpp 0beaed575ec865d81e6e3d83d8a0c894613acba4
src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
Diff: https://reviews.apache.org/r/36816/diff/
Testing (updated)
-------
* Add unit test cases: HealthCheckTest.HealthyTaskThroughHttp and HealthCheckTest.HealthyTaskNotMatchHttpStatuses
make check
Thanks,
haosdent huang
Re: Review Request 36816: Support HTTP checks in Mesos health check
program
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/
-----------------------------------------------------------
(Updated Dec. 12, 2015, 4:08 p.m.)
Review request for mesos, Adam B, Michael Park, and Timothy Chen.
Changes
-------
Address comments
Bugs: MESOS-2533
https://issues.apache.org/jira/browse/MESOS-2533
Repository: mesos
Description
-------
Support HTTP checks in Mesos health check program
Diffs (updated)
-----
include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77
src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2
src/health-check/main.cpp 0beaed575ec865d81e6e3d83d8a0c894613acba4
src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
Diff: https://reviews.apache.org/r/36816/diff/
Testing
-------
* Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp
make check
Thanks,
haosdent huang
Re: Review Request 36816: Support HTTP checks in Mesos health check
program
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/
-----------------------------------------------------------
(Updated Oct. 3, 2015, 6:01 p.m.)
Review request for mesos, Adam B, Michael Park, and Timothy Chen.
Changes
-------
Rebase
Bugs: MESOS-2533
https://issues.apache.org/jira/browse/MESOS-2533
Repository: mesos
Description
-------
Support HTTP checks in Mesos health check program
Diffs (updated)
-----
include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999
src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade
src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9
src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade
Diff: https://reviews.apache.org/r/36816/diff/
Testing
-------
* Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp
make check
Thanks,
haosdent huang