You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by mp...@apache.org on 2004/04/08 11:38:55 UTC
cvs commit: cocoon-2.1/src/blocks/forms/java/org/apache/cocoon/forms/transformation EffectPipe.java
mpo 2004/04/08 02:38:55
Modified: src/blocks/forms/java/org/apache/cocoon/forms/transformation
EffectPipe.java
Log:
Makes the nested Element object a bit more immutable.
And uses constructor chaining to normalize initialization logic.
Question: what is the use of the constructor with only prefix and uri?
Revision Changes Path
1.3 +12 -8 cocoon-2.1/src/blocks/forms/java/org/apache/cocoon/forms/transformation/EffectPipe.java
Index: EffectPipe.java
===================================================================
RCS file: /home/cvs/cocoon-2.1/src/blocks/forms/java/org/apache/cocoon/forms/transformation/EffectPipe.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- EffectPipe.java 9 Mar 2004 13:17:26 -0000 1.2
+++ EffectPipe.java 8 Apr 2004 09:38:55 -0000 1.3
@@ -60,23 +60,27 @@
protected static final int EVENT_COMMENT =18;
protected class Element {
- public String prefix;
- public String uri;
- public String loc;
- public String raw;
+ public final String prefix;
+ public final String uri;
+ public final String loc;
+ public final String raw;
public Attributes attrs;
public boolean mine;
public Element() {
- prefix = null; uri = null; loc = null; raw = null; attrs = XMLUtils.EMPTY_ATTRIBUTES; mine = true;
+ this(null, null, null, null, null);
}
public Element(String prefix, String uri) {
- this.prefix = prefix;
- this.uri = uri;
+ this(prefix, uri, null, null, null);
}
public Element(String uri, String loc, String raw, Attributes attrs) {
+ this(null, uri, loc, raw, attrs);
+ }
+
+ public Element(String prefix, String uri, String loc, String raw, Attributes attrs) {
+ this.prefix=prefix;
this.uri = uri;
this.loc = loc;
this.raw = raw;