You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by zhuoliu <gi...@git.apache.org> on 2016/01/14 03:54:50 UTC
[GitHub] storm pull request: [STORM-1472] Fix the errorTime bug and show th...
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1014
[STORM-1472] Fix the errorTime bug and show the time to be readable
1. Checking the code, find a bug in storm-core/src/clj/backtype/storm/ui/core.clj
"time" changed to "errorTime", however the REST info is still "time".
Error log link can not show any info for time.
2.In the error log link of UI, long of millisecond dates makes little sense to user. It would be nice to change it to be readable date.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm 1472
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1014.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1014
----
commit b48f02e39dcbec62a29da6989c98e004b6b1c940
Author: zhuol <zh...@yahoo-inc.com>
Date: 2016-01-14T02:52:59Z
[STORM-1472] Fix the errorTime bug and show the time to be readable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1472] Fix the errorTime bug and show th...
Posted by zhuoliu <gi...@git.apache.org>.
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1014#discussion_r49682555
--- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj ---
@@ -646,7 +646,7 @@
reverse)]
{"componentErrors"
(for [^ErrorInfo e errors]
- {"time" (* 1000 (long (.get_error_time_secs e)))
+ {"errorTime" (* 1000 (long (.get_error_time_secs e)))
--- End diff --
Here fix a bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1472] Fix the errorTime bug and show th...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1014#issuecomment-173266000
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1472] Fix the errorTime bug and show th...
Posted by zhuoliu <gi...@git.apache.org>.
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1014#discussion_r49682600
--- Diff: storm-core/src/jvm/org/apache/storm/scheduler/Cluster.java ---
@@ -32,11 +32,13 @@
public class Cluster {
/**
- * key: supervisor id, value: supervisor details
+ * key: supervisor id,
+ * value: supervisor's total and used resources, i.e. {totalMem, totalCpu, usedMem, usedCpu}
*/
private Map<String, SupervisorDetails> supervisors;
/**
* key: supervisor id, value: supervisor's total and used resources
+ * value: {requestedMemOnHeap, requestedMemOffHeap, requestedCpu, assignedMemOnHeap, assignedMemOffHeap, assignedCpu}
--- End diff --
Adding some comment to code (irrelevant).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1472] Fix the errorTime bug and show th...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1014
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---