[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #1011: MINIFICPP-1203 - Remove linter reported redundant virtuals

[GitBox <gi...@apache.org>]

hunyadi-dev commented on a change in pull request #1011:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1011#discussion_r596174880



##########
File path: extensions/expression-language/ProcessContextExpr.h
##########
@@ -51,16 +51,16 @@ class ProcessContextExpr : public core::ProcessContext {
         logger_(logging::LoggerFactory<ProcessContextExpr>::getLogger()) {
   }
   // Destructor
-  virtual ~ProcessContextExpr() = default;
+  ~ProcessContextExpr() = default;

Review comment:
       See below.

##########
File path: extensions/gps/GetGPS.h
##########
@@ -38,7 +38,7 @@ class GetGPS : public core::Processor {
     gpsdPort_ = "2947";
     gpsdWaitTime_ = 50000000;
   }
-  virtual ~GetGPS() = default;
+  ~GetGPS() = default;

Review comment:
       See below.

##########
File path: extensions/http-curl/HTTPCurlLoader.h
##########
@@ -37,11 +37,11 @@
 
 class HttpCurlObjectFactoryInitializer : public core::ObjectFactoryInitializer {
  public:
-  virtual bool initialize() {
+  bool initialize() {
     return curl_global_init(CURL_GLOBAL_DEFAULT) == CURLE_OK;
   }
 
-  virtual void deinitialize() {
+  void deinitialize() {

Review comment:
       See below.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org