You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Mark Doliner (Created) (JIRA)" <ji...@apache.org> on 2011/11/02 06:36:32 UTC
[jira] [Created] (CASSANDRA-3443) rpm should not remove user on
uninstall
rpm should not remove user on uninstall
---------------------------------------
Key: CASSANDRA-3443
URL: https://issues.apache.org/jira/browse/CASSANDRA-3443
Project: Cassandra
Issue Type: Bug
Components: Packaging
Reporter: Mark Doliner
Priority: Minor
Fedora's packaging guidelines state, "We never remove users or groups created by packages. There's no sane way to check if files owned by those users/groups are left behind (and even if there would, what would we do to them?), and leaving those behind with ownerships pointing to now nonexistent users/groups may result in security issues when a semantically unrelated user/group is created later and reuses the UID/GID. Also, in some setups deleting the user/group might not be possible or/nor desirable (eg. when using a shared remote user/group database). Cleanup of unused users/groups is left to the system administrators to take care of if they so desire." (that's from http://fedoraproject.org/wiki/Packaging/UsersAndGroups)
However, Cassandra's spec file in trunk and all branches contains this:
{noformat}
%preun
# only delete user on removal, not upgrade
if [ "$1" = "0" ]; then
userdel %{username}
fi
{noformat}
I agree with Fedora's reasoning. Additionally I'd like to add that stray accounts on a system are generally relatively harmless. I wonder if there was some intentional decision to diverge from Fedora's (and presumably Red Hat's) customary behavior? If not, I would suggest removing the above scriptlet from the Cassandra spec file. I'd be happy to provide a diff if that would be useful.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3443) rpm should not remove user on
uninstall
Posted by "Mark Doliner (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Doliner updated CASSANDRA-3443:
------------------------------------
Attachment: dont_remove_user_on_rpm_uninstall.diff
Here's a patch created against https://svn.apache.org/repos/asf/cassandra/trunk/
It applies cleanly to trunk as well as the following branches:
cassandra-0.7 (with 1 line offset)
cassandra-0.8
cassandra-1.0
Also, I see the "Submit Patch" button in Jira, which seems like it would be an appropriate way for me to upload this diff, but I don't see anywhere to upload a file when I click it.
> rpm should not remove user on uninstall
> ---------------------------------------
>
> Key: CASSANDRA-3443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3443
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
> Reporter: Mark Doliner
> Priority: Minor
> Labels: account, rpm, spec, user
> Attachments: dont_remove_user_on_rpm_uninstall.diff
>
>
> Fedora's packaging guidelines state, "We never remove users or groups created by packages. There's no sane way to check if files owned by those users/groups are left behind (and even if there would, what would we do to them?), and leaving those behind with ownerships pointing to now nonexistent users/groups may result in security issues when a semantically unrelated user/group is created later and reuses the UID/GID. Also, in some setups deleting the user/group might not be possible or/nor desirable (eg. when using a shared remote user/group database). Cleanup of unused users/groups is left to the system administrators to take care of if they so desire." (that's from http://fedoraproject.org/wiki/Packaging/UsersAndGroups)
> However, Cassandra's spec file in trunk and all branches contains this:
> {noformat}
> %preun
> # only delete user on removal, not upgrade
> if [ "$1" = "0" ]; then
> userdel %{username}
> fi
> {noformat}
> I agree with Fedora's reasoning. Additionally I'd like to add that stray accounts on a system are generally relatively harmless. I wonder if there was some intentional decision to diverge from Fedora's (and presumably Red Hat's) customary behavior? If not, I would suggest removing the above scriptlet from the Cassandra spec file. I'd be happy to provide a diff if that would be useful.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3443) rpm should not remove user on
uninstall
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141968#comment-13141968 ]
Jonathan Ellis commented on CASSANDRA-3443:
-------------------------------------------
We would welcome a patch.
> rpm should not remove user on uninstall
> ---------------------------------------
>
> Key: CASSANDRA-3443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3443
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
> Reporter: Mark Doliner
> Priority: Minor
> Labels: account, rpm, spec, user
>
> Fedora's packaging guidelines state, "We never remove users or groups created by packages. There's no sane way to check if files owned by those users/groups are left behind (and even if there would, what would we do to them?), and leaving those behind with ownerships pointing to now nonexistent users/groups may result in security issues when a semantically unrelated user/group is created later and reuses the UID/GID. Also, in some setups deleting the user/group might not be possible or/nor desirable (eg. when using a shared remote user/group database). Cleanup of unused users/groups is left to the system administrators to take care of if they so desire." (that's from http://fedoraproject.org/wiki/Packaging/UsersAndGroups)
> However, Cassandra's spec file in trunk and all branches contains this:
> {noformat}
> %preun
> # only delete user on removal, not upgrade
> if [ "$1" = "0" ]; then
> userdel %{username}
> fi
> {noformat}
> I agree with Fedora's reasoning. Additionally I'd like to add that stray accounts on a system are generally relatively harmless. I wonder if there was some intentional decision to diverge from Fedora's (and presumably Red Hat's) customary behavior? If not, I would suggest removing the above scriptlet from the Cassandra spec file. I'd be happy to provide a diff if that would be useful.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3443) rpm should not remove user on
uninstall
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142070#comment-13142070 ]
Jonathan Ellis commented on CASSANDRA-3443:
-------------------------------------------
You want "more actions -> attach files."
> rpm should not remove user on uninstall
> ---------------------------------------
>
> Key: CASSANDRA-3443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3443
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
> Reporter: Mark Doliner
> Priority: Minor
> Labels: account, rpm, spec, user
> Attachments: dont_remove_user_on_rpm_uninstall.diff
>
>
> Fedora's packaging guidelines state, "We never remove users or groups created by packages. There's no sane way to check if files owned by those users/groups are left behind (and even if there would, what would we do to them?), and leaving those behind with ownerships pointing to now nonexistent users/groups may result in security issues when a semantically unrelated user/group is created later and reuses the UID/GID. Also, in some setups deleting the user/group might not be possible or/nor desirable (eg. when using a shared remote user/group database). Cleanup of unused users/groups is left to the system administrators to take care of if they so desire." (that's from http://fedoraproject.org/wiki/Packaging/UsersAndGroups)
> However, Cassandra's spec file in trunk and all branches contains this:
> {noformat}
> %preun
> # only delete user on removal, not upgrade
> if [ "$1" = "0" ]; then
> userdel %{username}
> fi
> {noformat}
> I agree with Fedora's reasoning. Additionally I'd like to add that stray accounts on a system are generally relatively harmless. I wonder if there was some intentional decision to diverge from Fedora's (and presumably Red Hat's) customary behavior? If not, I would suggest removing the above scriptlet from the Cassandra spec file. I'd be happy to provide a diff if that would be useful.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3443) rpm should not remove user on
uninstall
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3443:
--------------------------------------
Reviewer: thepaul
> rpm should not remove user on uninstall
> ---------------------------------------
>
> Key: CASSANDRA-3443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3443
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
> Reporter: Mark Doliner
> Priority: Minor
> Labels: account, rpm, spec, user
> Attachments: dont_remove_user_on_rpm_uninstall.diff
>
>
> Fedora's packaging guidelines state, "We never remove users or groups created by packages. There's no sane way to check if files owned by those users/groups are left behind (and even if there would, what would we do to them?), and leaving those behind with ownerships pointing to now nonexistent users/groups may result in security issues when a semantically unrelated user/group is created later and reuses the UID/GID. Also, in some setups deleting the user/group might not be possible or/nor desirable (eg. when using a shared remote user/group database). Cleanup of unused users/groups is left to the system administrators to take care of if they so desire." (that's from http://fedoraproject.org/wiki/Packaging/UsersAndGroups)
> However, Cassandra's spec file in trunk and all branches contains this:
> {noformat}
> %preun
> # only delete user on removal, not upgrade
> if [ "$1" = "0" ]; then
> userdel %{username}
> fi
> {noformat}
> I agree with Fedora's reasoning. Additionally I'd like to add that stray accounts on a system are generally relatively harmless. I wonder if there was some intentional decision to diverge from Fedora's (and presumably Red Hat's) customary behavior? If not, I would suggest removing the above scriptlet from the Cassandra spec file. I'd be happy to provide a diff if that would be useful.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3443) rpm should not remove user on
uninstall
Posted by "Mark Doliner (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142449#comment-13142449 ]
Mark Doliner commented on CASSANDRA-3443:
-----------------------------------------
Ah, cool. That's what I ended up using. Thanks
> rpm should not remove user on uninstall
> ---------------------------------------
>
> Key: CASSANDRA-3443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3443
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
> Reporter: Mark Doliner
> Priority: Minor
> Labels: account, rpm, spec, user
> Attachments: dont_remove_user_on_rpm_uninstall.diff
>
>
> Fedora's packaging guidelines state, "We never remove users or groups created by packages. There's no sane way to check if files owned by those users/groups are left behind (and even if there would, what would we do to them?), and leaving those behind with ownerships pointing to now nonexistent users/groups may result in security issues when a semantically unrelated user/group is created later and reuses the UID/GID. Also, in some setups deleting the user/group might not be possible or/nor desirable (eg. when using a shared remote user/group database). Cleanup of unused users/groups is left to the system administrators to take care of if they so desire." (that's from http://fedoraproject.org/wiki/Packaging/UsersAndGroups)
> However, Cassandra's spec file in trunk and all branches contains this:
> {noformat}
> %preun
> # only delete user on removal, not upgrade
> if [ "$1" = "0" ]; then
> userdel %{username}
> fi
> {noformat}
> I agree with Fedora's reasoning. Additionally I'd like to add that stray accounts on a system are generally relatively harmless. I wonder if there was some intentional decision to diverge from Fedora's (and presumably Red Hat's) customary behavior? If not, I would suggest removing the above scriptlet from the Cassandra spec file. I'd be happy to provide a diff if that would be useful.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira