You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/13 04:50:29 UTC

[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports

kezhenxu94 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r945006780


##########
pom.xml:
##########
@@ -648,13 +648,22 @@
                         <eclipse>
                             <file>style/spotless_dolphinscheduler_formatter.xml</file>
                         </eclipse>
+                        <removeUnusedImports />
+                        <importOrder>
+                            <file>style/eclipse.importorder</file>
+                        </importOrder>
+                        <replaceRegex>

Review Comment:
   This removes the star import. But will it instead replaces the star import with the used specific class import? If not, this will cause compiling failed. Can you change a class with this example?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org