You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/13 21:29:47 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #7118: [AIRFLOW-6521]: add project param to bigQuery hook .getSchema method

mik-laj commented on a change in pull request #7118: [AIRFLOW-6521]: add project param to bigQuery hook .getSchema method
URL: https://github.com/apache/airflow/pull/7118#discussion_r366038304
 
 

 ##########
 File path: airflow/gcp/hooks/bigquery.py
 ##########
 @@ -1453,17 +1453,21 @@ def get_dataset_tables(self, dataset_id: str, project_id: Optional[str] = None,
             **optional_params).execute(num_retries=self.num_retries))
 
     @CloudBaseHook.catch_http_exception
-    def get_schema(self, dataset_id: str, table_id: str) -> Dict:
 
 Review comment:
   Can you use `@CloudBaseHook.fallback_to_default_project_id`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services