You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2026/09/15 09:08:14 UTC
[Impala-ASF-CR] IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24846
Change subject: IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
......................................................................
IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
The goal is to be able to exclude specific artifacts in groups
pinned to specific versions. The include list in version pinned
groups have * for artifact, which would override the exclude rules.
Also removed a duplicate rule (org.bouncycastle:bcprov-jdk15on).
Change-Id: I8f496f95199af1d7131c528b65e0b1277ba3aaff
---
M fe/pom.xml
1 file changed, 35 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/24846/1
--
To view, visit http://gerrit.cloudera.org:8080/24846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f496f95199af1d7131c528b65e0b1277ba3aaff
Gerrit-Change-Number: 24846
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24846 )
Change subject: IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f496f95199af1d7131c528b65e0b1277ba3aaff
Gerrit-Change-Number: 24846
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 18:44:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24846 )
Change subject: IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f496f95199af1d7131c528b65e0b1277ba3aaff
Gerrit-Change-Number: 24846
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 15:21:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24846 )
Change subject: IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f496f95199af1d7131c528b65e0b1277ba3aaff
Gerrit-Change-Number: 24846
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 23:13:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24846 )
Change subject: IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
......................................................................
IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
The goal is to be able to exclude specific artifacts in groups
pinned to specific versions. The include list in version pinned
groups have * for artifact, which would override the exclude rules.
Also removed a duplicate rule (org.bouncycastle:bcprov-jdk15on).
Change-Id: I8f496f95199af1d7131c528b65e0b1277ba3aaff
Reviewed-on: http://gerrit.cloudera.org:8080/24846
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/pom.xml
1 file changed, 35 insertions(+), 12 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/24846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f496f95199af1d7131c528b65e0b1277ba3aaff
Gerrit-Change-Number: 24846
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24846 )
Change subject: IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24026/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f496f95199af1d7131c528b65e0b1277ba3aaff
Gerrit-Change-Number: 24846
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 09:31:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24846 )
Change subject: IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/24846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f496f95199af1d7131c528b65e0b1277ba3aaff
Gerrit-Change-Number: 24846
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 14:27:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24846 )
Change subject: IMPALA-15351: Split maven-enforcer-plugin rules in 2 passes
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14046/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f496f95199af1d7131c528b65e0b1277ba3aaff
Gerrit-Change-Number: 24846
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 18:44:24 +0000
Gerrit-HasComments: No