You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@impala.apache.org by "Tim Armstrong (JIRA)" <ji...@apache.org> on 2019/05/15 22:38:01 UTC

[jira] [Resolved] (IMPALA-7331) Add Char codegen support to helpers

     [ https://issues.apache.org/jira/browse/IMPALA-7331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Armstrong resolved IMPALA-7331.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 3.3.0

> Add Char codegen support to helpers
> -----------------------------------
>
>                 Key: IMPALA-7331
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7331
>             Project: IMPALA
>          Issue Type: Sub-task
>          Components: Backend
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>              Labels: codegen
>             Fix For: Impala 3.3.0
>
>
> There are a lot of generic helpers with missing TYPE_CHAR support. We need to add char to those. The tuple layout is identical to TYPE_FIXED_UDA_INTERMEDIATE and the UDF StringVal type is used the same as TYPE_STRING, so mostly this requires using those code paths for CHAR and doing appropriate testing to ensure that it works (the random query generator may help here!).
> E.g.
> https://github.com/apache/impala/blob/4a39e7c/be/src/codegen/codegen-anyval.cc#L58
> https://github.com/apache/impala/blob/4a39e7c29f7b910c9ae0d622b355e9362c17aaec/be/src/runtime/descriptors.cc#L712



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)