fs-fs-fuzzy-test fails to build due to missing dependency

[Alexey Neyman <st...@att.net>]

Hi all,

fs-fs-fuzzy-test fails to build for me (Ubuntu 14.04 + current updates) 
with a "DSO missing from the command line" error. Anyone objecting 
to the attached patch?

[[[
* build.conf
  (fs-fs-fuzzy-test) Add libsvn_repos as a dependency.
]]]

Regards,
Alexey.

Re: fs-fs-fuzzy-test fails to build due to missing dependency

[Stefan Fuhrmann <st...@wandisco.com>]

On Tue, Sep 9, 2014 at 7:56 AM, Alexey Neyman <st...@att.net> wrote:

>  Hi all,
>
>
>
> fs-fs-fuzzy-test fails to build for me (Ubuntu 14.04 + current updates)
> with a "DSO missing from the command line" error. Anyone objecting to the
> attached patch?
>
>
>
> [[[
>
> * build.conf
>
> (fs-fs-fuzzy-test) Add libsvn_repos as a dependency.
>
> ]]]
>

Makes absolute sense. Thanks for fixing this!

-- Stefan^2.

Re: fs-fs-fuzzy-test fails to build due to missing dependency

[Julian Foad <ju...@btopenworld.com>]

Alexey Neyman wrote:
> fs-fs-fuzzy-test fails to build for me (Ubuntu 14.04 + current updates) with a
> "DSO missing from the command line" error. Anyone objecting to the attached patch?
> 
> [[[
> * build.conf
> (fs-fs-fuzzy-test) Add libsvn_repos as a dependency.
> ]]]

Me too, on 64-bit Linux (Ubuntu 14.04) using GCC, doing an out-of-tree build. The error is:

/usr/bin/ld: .libs/fs-fs-fuzzy-test.o: undefined reference to symbol 'svn_repos_verify_fs3'
/.../subversion/libsvn_repos/.libs/libsvn_repos-1.so.0: error adding symbols: DSO missing from command line

Your patch looks right and works for me, so +1. (Please add "Approved by: julianfoad" in the log message. Thanks.)

The other possibility is that Stefan (the author of that test) might want to avoid using libsvn_repos and call a lower-level FS verify function instead. If that's the case he can change it later. Un-breaking the build is the first priority.

- Julian