You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/12 21:49:52 UTC
[GitHub] [solr] tflobbe opened a new pull request #14: SOLR-15154: Document new options for credentials
tflobbe opened a new pull request #14:
URL: https://github.com/apache/solr/pull/14
Documentation for the client changes introduced in SOLR-15154
Moved from https://github.com/apache/lucene-solr/pull/2468
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] tflobbe commented on a change in pull request #14: SOLR-15154: Document new options for credentials
Posted by GitBox <gi...@apache.org>.
tflobbe commented on a change in pull request #14:
URL: https://github.com/apache/solr/pull/14#discussion_r602618027
##########
File path: solr/solr-ref-guide/src/basic-authentication-plugin.adoc
##########
@@ -220,6 +220,17 @@ QueryResponse rsp = req.process(solrClient);
While this is method is simple, it can often be inconvenient to ensure the credentials are provided everywhere they're needed. It also doesn't work with the many `SolrClient` methods which don't consume `SolrRequest` objects.
+=== Per-Client credentials
+Http2SolrClient support setting the credentials a the client level when building it. This will ensure all requests issued with this particular client get the Basic Authentication headers set.
Review comment:
ugh, one line, two typos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] tflobbe merged pull request #14: SOLR-15154: Document new options for credentials
Posted by GitBox <gi...@apache.org>.
tflobbe merged pull request #14:
URL: https://github.com/apache/solr/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #14: SOLR-15154: Document new options for credentials
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #14:
URL: https://github.com/apache/solr/pull/14#discussion_r598863975
##########
File path: solr/solr-ref-guide/src/basic-authentication-plugin.adoc
##########
@@ -220,6 +220,17 @@ QueryResponse rsp = req.process(solrClient);
While this is method is simple, it can often be inconvenient to ensure the credentials are provided everywhere they're needed. It also doesn't work with the many `SolrClient` methods which don't consume `SolrRequest` objects.
+=== Per-Client credentials
+Http2SolrClient support setting the credentials a the client level when building it. This will ensure all requests issued with this particular client get the Basic Authentication headers set.
Review comment:
s/support/supports
s/a/at
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org