You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by vi...@apache.org on 2014/06/10 21:24:04 UTC
git commit: Switched to subprocess.Popen to get stdout streamed from
verify-reviews.
Repository: mesos
Updated Branches:
refs/heads/master 7212db8c4 -> 7013f47c3
Switched to subprocess.Popen to get stdout streamed from
verify-reviews.
Using Popen instead of check_output means that the output is streamed
to the console. As such, runs that timeout will still include partial
logs enabling us to debug any issues.
Review: https://reviews.apache.org/r/22422
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/7013f47c
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/7013f47c
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/7013f47c
Branch: refs/heads/master
Commit: 7013f47c3b59314db2b560d67edf1d01afd4a2db
Parents: 7212db8
Author: Dominic Hamon <dh...@twopensource.com>
Authored: Tue Jun 10 12:22:24 2014 -0700
Committer: Vinod Kone <vi...@twitter.com>
Committed: Tue Jun 10 12:22:25 2014 -0700
----------------------------------------------------------------------
support/verify-reviews.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/7013f47c/support/verify-reviews.py
----------------------------------------------------------------------
diff --git a/support/verify-reviews.py b/support/verify-reviews.py
index a84f9ce..1a57c58 100755
--- a/support/verify-reviews.py
+++ b/support/verify-reviews.py
@@ -40,8 +40,10 @@ if len(sys.argv) >= 5:
def shell(command):
print command
- return subprocess.check_output(
- command, stderr=subprocess.STDOUT, shell=True)
+ proc = subprocess.Popen(command, stderr=subprocess.STDOUT, shell=True)
+ (out, _) = proc.communicate()
+ if proc.returncode != 0:
+ raise subprocess.CalledProcessError(proc.returncode, command, out)
def api(url, data=None):