You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/30 07:26:03 UTC

[GitHub] [flink] BLHofn opened a new pull request #17611: Release 1.12

BLHofn opened a new pull request #17611:
URL: https://github.com/apache/flink/pull/17611


   Fix the interval join java case in the official document case
   
   Document link:
   https://ci.apache.org/projects/flink/flink-docs-release-1.12/dev/stream/operators/joining.html#interval-join
   
   1、Your case is:
   import org.apache.flink.api.java.functions.KeySelector;
   import org.apache.flink.streaming.api.functions.co.ProcessJoinFunction;
   import org.apache.flink.streaming.api.windowing.time.Time;
   
   ...
   
   DataStream<Integer> orangeStream = ...
   DataStream<Integer> greenStream = ...
   
   orangeStream
       .keyBy(<KeySelector>)
       .intervalJoin(greenStream.keyBy(<KeySelector>))
       .between(Time.milliseconds(-2), Time.milliseconds(1))
       .process (new ProcessJoinFunction<Integer, Integer, String(){
   
           @Override
           public void processElement(Integer left, Integer right, Context ctx, Collector<String> out) {
               out.collect(first + "," + second);
           }
       });
   
   2、After repair:
   import org.apache.flink.api.java.functions.KeySelector;
   import org.apache.flink.streaming.api.functions.co.ProcessJoinFunction;
   import org.apache.flink.streaming.api.windowing.time.Time;
   
   ...
   
   DataStream<Integer> orangeStream = ...
   DataStream<Integer> greenStream = ...
   
   orangeStream
       .keyBy(<KeySelector>)
       .intervalJoin(greenStream.keyBy(<KeySelector>))
       .between(Time.milliseconds(-2), Time.milliseconds(1))
       .process (new ProcessJoinFunction<Integer, Integer, String(){
   
           @Override
           public void processElement(Integer left, Integer right, Context ctx, Collector<String> out) {
               out.collect(left + "," + right);
           }
       });
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17611: Release 1.12

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17611:
URL: https://github.com/apache/flink/pull/17611#issuecomment-955165472


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9233b9b6513d6e912a620b8f18a93fa73909622c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25666",
       "triggerID" : "9233b9b6513d6e912a620b8f18a93fa73909622c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9233b9b6513d6e912a620b8f18a93fa73909622c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25666) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zentol commented on pull request #17611: Release 1.12

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #17611:
URL: https://github.com/apache/flink/pull/17611#issuecomment-956034109


   Please re-open the PR from the correct branch. As is you're attempting to merge 700+ commits from the release-1.12 branch into master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17611: Release 1.12

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17611:
URL: https://github.com/apache/flink/pull/17611#issuecomment-955165472


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9233b9b6513d6e912a620b8f18a93fa73909622c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9233b9b6513d6e912a620b8f18a93fa73909622c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9233b9b6513d6e912a620b8f18a93fa73909622c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17611: Release 1.12

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17611:
URL: https://github.com/apache/flink/pull/17611#issuecomment-955165472


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9233b9b6513d6e912a620b8f18a93fa73909622c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25666",
       "triggerID" : "9233b9b6513d6e912a620b8f18a93fa73909622c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9233b9b6513d6e912a620b8f18a93fa73909622c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25666) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17611: Release 1.12

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17611:
URL: https://github.com/apache/flink/pull/17611#issuecomment-955166631


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 9233b9b6513d6e912a620b8f18a93fa73909622c (Sat Oct 30 07:36:14 UTC 2021)
   
   **Warnings:**
    * **14 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **Invalid pull request title: No valid Jira ID provided**
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zentol closed pull request #17611: Release 1.12

Posted by GitBox <gi...@apache.org>.
zentol closed pull request #17611:
URL: https://github.com/apache/flink/pull/17611


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org