You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/04/28 09:56:14 UTC

[GitHub] [cloudstack] Pearl1594 opened a new pull request #4964: ui: Fix Settings Tab view

Pearl1594 opened a new pull request #4964:
URL: https://github.com/apache/cloudstack/pull/4964


   ### Description
   
   This PR fixes the issue noticed when traversing to the Settings tab on account, domain, Zone, Cluster, Storagepool Sections. On navigating to the Settings tabs, it displays all the configuration as opposed to only displaying the configuration specific to that scope as the scope specific parameter isn't passed until refreshed.
   
   ![image](https://user-images.githubusercontent.com/10495417/116257429-ac6f3d80-a791-11eb-834d-5f83c4586b00.png)
   
   Only after refresh are we able to see the correct configuration:
   
   ![image](https://user-images.githubusercontent.com/10495417/116257485-b98c2c80-a791-11eb-9bf3-e932a6fb83e7.png)
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   Tested various views specified above
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4964: ui: Fix Settings Tab view

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4964:
URL: https://github.com/apache/cloudstack/pull/4964


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4964: ui: Fix Settings Tab view

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4964:
URL: https://github.com/apache/cloudstack/pull/4964#issuecomment-828324524


   @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4964: ui: Fix Settings Tab view

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4964:
URL: https://github.com/apache/cloudstack/pull/4964#discussion_r623124932



##########
File path: ui/src/components/view/SettingsTab.vue
##########
@@ -96,7 +96,7 @@ export default {
       filter: ''
     }
   },
-  beforeMount () {
+  created () {

Review comment:
       Ping ^^ @utchoang @shwstppr @davidjumani @Pearl1594 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4964: ui: Fix Settings Tab view

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4964:
URL: https://github.com/apache/cloudstack/pull/4964#issuecomment-828327256


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4964 (SL-JID-112)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4964: ui: Fix Settings Tab view

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4964:
URL: https://github.com/apache/cloudstack/pull/4964#discussion_r622095409



##########
File path: ui/src/components/view/SettingsTab.vue
##########
@@ -96,7 +96,7 @@ export default {
       filter: ''
     }
   },
-  beforeMount () {
+  created () {

Review comment:
       @utchoang @shwstppr @davidjumani - I similar change in quite a few recent PRs - should we check/scan/fix all components?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on a change in pull request #4964: ui: Fix Settings Tab view

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4964:
URL: https://github.com/apache/cloudstack/pull/4964#discussion_r623592770



##########
File path: ui/src/components/view/SettingsTab.vue
##########
@@ -96,7 +96,7 @@ export default {
       filter: ''
     }
   },
-  beforeMount () {
+  created () {

Review comment:
       That might require considerable time testing. IMO, fix it as it comes along @rhtyd 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #4964: ui: Fix Settings Tab view

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4964:
URL: https://github.com/apache/cloudstack/pull/4964#issuecomment-828324068


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org