You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/05/20 23:54:01 UTC

[GitHub] [trafficcontrol] rawlinp opened a new pull request #4710: Fix cachegroups DB query join with topology_cachegroup

rawlinp opened a new pull request #4710:
URL: https://github.com/apache/trafficcontrol/pull/4710


   ## What does this PR (Pull Request) do?
   
   After support was added for the `?topology` query parameter in the `GET /cachegroups` API, it was found that duplicate cachegroups would be returned if a cachegroup was used in more than one topology. This PR fixes that query to only join on `topology_cachegroup` if the `?topology` query parameter is given.
   
   - [x] This PR is not related to any Issue
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   
   Run the unit tests and TO API tests, verify they pass.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   
   - master
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests
   - [x] bugfix, no docs necessary
   - [x] unreleased bug, no changelog necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mattjackson220 merged pull request #4710: Fix cachegroups DB query join with topology_cachegroup

Posted by GitBox <gi...@apache.org>.
mattjackson220 merged pull request #4710:
URL: https://github.com/apache/trafficcontrol/pull/4710


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org