[GitHub] ccollins476ad commented on a change in pull request #197: syscfg: error detection after API resolution

[GitBox <gi...@apache.org>]

ccollins476ad commented on a change in pull request #197: syscfg: error detection after API resolution
URL: https://github.com/apache/mynewt-newt/pull/197#discussion_r206665442
 
 

 ##########
 File path: newt/syscfg/syscfg.go
 ##########
 @@ -1009,6 +1009,15 @@ func (cfg *Cfg) detectAmbiguities() {
 	}
 }
 
+// Detects and records errors in the build's syscfg.  This should only be
+// called after APIs are resolved to avoid false positives.
+func (cfg *Cfg) DetectErrors(flashMap flash.FlashMap) {
 
 Review comment:
   Yeah, that's a good question.  I never really know whether to pass by value or pointer in Go.  These days I tend to pass by value unless the function is intended to modify the data since there is no `const`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services