You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/01/11 22:03:44 UTC
Re: Review Request 55026: Windows: Shortened test directories on
Windows to avoid path errors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55026/#review161309
-----------------------------------------------------------
Ship it!
LGTM.
As some background (and for your information), these temporary directories are created in tests like `environment->mktemp()`. This is something we use for debugging, as having the test name in the temporary directory makes tracking down failed/crashed tests easier. With this change, it will be even more important for tests to be run with `--verbose`; as long as tests are verbose, we can track down the appropriate temporary folders for almost all debugging purposes.
- Joseph Wu
On Dec. 24, 2016, 3:14 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55026/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2016, 3:14 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently some tests that use particularly long sandbox paths will due
> to the notorious Windows path length limitations. Here, we change the
> sandbox directory default on Windows agent tests to be something shorter
> than the Unix equivalent in order to avoid these errors.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp a683d8c221635f81906abbead1e01d2469850d93
>
> Diff: https://reviews.apache.org/r/55026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55026: Windows: Shortened test directories on
Windows to avoid path errors.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Jan. 11, 2017, 10:03 p.m., Joseph Wu wrote:
> > LGTM.
> >
> > As some background (and for your information), these temporary directories are created in tests like `environment->mktemp()`. This is something we use for debugging, as having the test name in the temporary directory makes tracking down failed/crashed tests easier. With this change, it will be even more important for tests to be run with `--verbose`; as long as tests are verbose, we can track down the appropriate temporary folders for almost all debugging purposes.
100% agreed. We need to solve the path issue and go back to the way it was. Thanks for doing due diligence. :)
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55026/#review161309
-----------------------------------------------------------
On Dec. 24, 2016, 11:14 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55026/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2016, 11:14 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently some tests that use particularly long sandbox paths will due
> to the notorious Windows path length limitations. Here, we change the
> sandbox directory default on Windows agent tests to be something shorter
> than the Unix equivalent in order to avoid these errors.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp a683d8c221635f81906abbead1e01d2469850d93
>
> Diff: https://reviews.apache.org/r/55026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>