You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/03/31 18:35:00 UTC
[jira] [Commented] (GEODE-7625) Remove broken DH support
[ https://issues.apache.org/jira/browse/GEODE-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072061#comment-17072061 ]
ASF subversion and git services commented on GEODE-7625:
--------------------------------------------------------
Commit 6b46256dd03d5406f19c8cb465df03b61a30fb8a in geode-native's branch refs/heads/master from Blake Bender
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=6b46256 ]
Revert "GEODE-7625: Remove broken Diffie-Hellman code"
This reverts commit de672d7faded5b17c8c22ecabaa6aaf3deab24cb.
- Change somehow (???) broke Ubuntu builds of cryptoimpl library. Looks like something isn't linking in SSL library like it should
- reverting back to known good state for now, since it'll take a little while to investigate breakage
> Remove broken DH support
> ------------------------
>
> Key: GEODE-7625
> URL: https://issues.apache.org/jira/browse/GEODE-7625
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: Jacob Barrett
> Assignee: Ernest Burghardt
> Priority: Major
> Fix For: 1.12.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The DH support in geode native client has been broken since donation. There are currently no enabled tests for DH. The current sources compile but guarantee a memory access violation. All 4 implementation in the code base have the same bug. I recommend removal of the source to cleanup the code and build.
> If DH support is required in the client at a later date we can either recover the sources or better yet start over with testing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)