You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/17 18:33:55 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5028: eventfd: Remove the unused and private eventfd_get_minor
xiaoxiang781216 opened a new pull request #5028:
URL: https://github.com/apache/incubator-nuttx/pull/5028
## Summary
since it isn't defined by Linux kernel too
## Impact
Remove eventfd_get_minor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5028: eventfd: Remove the unused and private eventfd_get_minor
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5028:
URL: https://github.com/apache/incubator-nuttx/pull/5028#discussion_r771790392
##########
File path: fs/vfs/fs_eventfd.c
##########
@@ -41,7 +41,7 @@
****************************************************************************/
#ifndef CONFIG_EVENT_FD_VFS_PATH
-#define CONFIG_EVENT_FD_VFS_PATH "/dev"
+#define CONFIG_EVENT_FD_VFS_PATH "/dev/event"
Review comment:
```suggestion
#define CONFIG_EVENT_FD_VFS_PATH "/var/event"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5028: eventfd: Remove the unused and private eventfd_get_minor
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5028:
URL: https://github.com/apache/incubator-nuttx/pull/5028#discussion_r771644332
##########
File path: include/nuttx/fs/ioctl.h
##########
@@ -169,10 +169,6 @@
* int value.
* OUT: Origin option.
*/
-#define FIOC_MINOR _FIOC(0x000c) /* IN: None
- * OUT: Integer that contains device
- * minor number
- */
#define FIOCLEX _FIOC(0x000d) /* IN: None
Review comment:
```suggestion
#define FIOCLEX _FIOC(0x000c) /* IN: None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5028: eventfd: Remove the unused and private eventfd_get_minor
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5028:
URL: https://github.com/apache/incubator-nuttx/pull/5028#discussion_r771823737
##########
File path: fs/vfs/fs_eventfd.c
##########
@@ -41,7 +41,7 @@
****************************************************************************/
#ifndef CONFIG_EVENT_FD_VFS_PATH
-#define CONFIG_EVENT_FD_VFS_PATH "/dev"
+#define CONFIG_EVENT_FD_VFS_PATH "/dev/event"
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5028: eventfd: Remove the unused and private eventfd_get_minor
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5028:
URL: https://github.com/apache/incubator-nuttx/pull/5028#discussion_r771846846
##########
File path: fs/vfs/fs_eventfd.c
##########
@@ -66,10 +66,10 @@ struct eventfd_priv_s
sem_t exclsem; /* Enforces device exclusive access */
eventfd_waiter_sem_t *rdsems; /* List of blocking readers */
eventfd_waiter_sem_t *wrsems; /* List of blocking writers */
- eventfd_t counter; /* eventfd counter */
- size_t minor; /* eventfd minor number */
- uint8_t crefs; /* References counts on eventfd (max: 255) */
- uint8_t mode_semaphore; /* eventfd mode (semaphore or counter) */
+ eventfd_t counter; /* eventfd counter */
+ unsigned int minor; /* eventfd minor number */
+ uint8_t crefs; /* References counts on eventfd (max: 255) */
+ uint8_t mode_semaphore; /* eventfd mode (semaphore or counter) */
Review comment:
Should we use `bool` here instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5028: eventfd: Remove the unused and private eventfd_get_minor
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5028:
URL: https://github.com/apache/incubator-nuttx/pull/5028#discussion_r771785728
##########
File path: fs/vfs/fs_eventfd.c
##########
@@ -121,8 +119,8 @@ static const struct file_operations g_eventfd_fops =
eventfd_do_close, /* close */
eventfd_do_read, /* read */
eventfd_do_write, /* write */
- 0, /* seek */
- eventfd_do_ioctl /* ioctl */
+ NULL, /* seek */
+ NULL, /* ioctl */
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5028: eventfd: Remove the unused and private eventfd_get_minor
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5028:
URL: https://github.com/apache/incubator-nuttx/pull/5028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5028: eventfd: Remove the unused and private eventfd_get_minor
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5028:
URL: https://github.com/apache/incubator-nuttx/pull/5028#discussion_r771786024
##########
File path: include/nuttx/fs/ioctl.h
##########
@@ -169,10 +169,6 @@
* int value.
* OUT: Origin option.
*/
-#define FIOC_MINOR _FIOC(0x000c) /* IN: None
- * OUT: Integer that contains device
- * minor number
- */
#define FIOCLEX _FIOC(0x000d) /* IN: None
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5028: eventfd: Remove the unused and private eventfd_get_minor
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5028:
URL: https://github.com/apache/incubator-nuttx/pull/5028#discussion_r771645327
##########
File path: fs/vfs/fs_eventfd.c
##########
@@ -121,8 +119,8 @@ static const struct file_operations g_eventfd_fops =
eventfd_do_close, /* close */
eventfd_do_read, /* read */
eventfd_do_write, /* write */
- 0, /* seek */
- eventfd_do_ioctl /* ioctl */
+ NULL, /* seek */
+ NULL, /* ioctl */
Review comment:
```suggestion
NULL /* ioctl */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5028: eventfd: Remove the unused and private eventfd_get_minor
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5028:
URL: https://github.com/apache/incubator-nuttx/pull/5028#discussion_r771645703
##########
File path: include/nuttx/fs/ioctl.h
##########
@@ -169,10 +169,6 @@
* int value.
* OUT: Origin option.
*/
-#define FIOC_MINOR _FIOC(0x000c) /* IN: None
- * OUT: Integer that contains device
- * minor number
- */
#define FIOCLEX _FIOC(0x000d) /* IN: None
Review comment:
```suggestion
#define FIOCLEX _FIOC(0x000c) /* IN: None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5028: eventfd: Remove the unused and private eventfd_get_minor
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5028:
URL: https://github.com/apache/incubator-nuttx/pull/5028#discussion_r771852539
##########
File path: fs/vfs/fs_eventfd.c
##########
@@ -66,10 +66,10 @@ struct eventfd_priv_s
sem_t exclsem; /* Enforces device exclusive access */
eventfd_waiter_sem_t *rdsems; /* List of blocking readers */
eventfd_waiter_sem_t *wrsems; /* List of blocking writers */
- eventfd_t counter; /* eventfd counter */
- size_t minor; /* eventfd minor number */
- uint8_t crefs; /* References counts on eventfd (max: 255) */
- uint8_t mode_semaphore; /* eventfd mode (semaphore or counter) */
+ eventfd_t counter; /* eventfd counter */
+ unsigned int minor; /* eventfd minor number */
+ uint8_t crefs; /* References counts on eventfd (max: 255) */
+ uint8_t mode_semaphore; /* eventfd mode (semaphore or counter) */
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org