You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by "Ben Kietzman (Jira)" <ji...@apache.org> on 2020/03/09 15:03:00 UTC

[jira] [Created] (ARROW-8037) [Developer][Integration] Consolidate example JSON and test/validate uniformly

Ben Kietzman created ARROW-8037:
-----------------------------------

             Summary: [Developer][Integration] Consolidate example JSON and test/validate uniformly
                 Key: ARROW-8037
                 URL: https://issues.apache.org/jira/browse/ARROW-8037
             Project: Apache Arrow
          Issue Type: Improvement
          Components: Integration
    Affects Versions: 0.16.0
            Reporter: Ben Kietzman
             Fix For: 1.0.0


Currently the schema for the integration JSON representation is expressed in prose only. It should be rewritten using a JSON schema representation and used to validate generated as well as (checked-in) example JSON. {{jsonschema}} would work https://python-jsonschema.readthedocs.io/en/stable/validate/

Additionally, languages unit test their JSON parsers/converters against differing example JSON:

C++ includes some inline https://github.com/apache/arrow/blob/b0bb6841af91ed2fddc201ca1ff6bedac7629e2e/cpp/src/arrow/ipc/json_integration_test.cc#L317-L346

While Java uses an explicit file https://github.com/apache/arrow/blob/5b783fe35284c97f6bcf107650ba7cfd66a76750/java/tools/src/test/java/org/apache/arrow/tools/TestIntegration.java#L189

This is brittle and difficult to discover. A single directory of checked-in example JSON should be assembled, against which all languages should unit test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)