[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #448: Correct typo about PARTITION_DATA_ID_START

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #448: Correct typo about PARTITION_DATA_ID_START
URL: https://github.com/apache/incubator-iceberg/pull/448#discussion_r320848311
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
 ##########
 @@ -109,7 +109,10 @@ public int specId() {
       PartitionField field = fields[i];
       Type sourceType = schema.findType(field.sourceId());
       Type resultType = field.transform().getResultType(sourceType);
-      // assign ids for partition fields starting at 100 to leave room for data file's other fields
+      /**
+       * assign ids for partition fields starting at {@link PARTITION_DATA_ID_START}
+       * to leave room for data file's other fields
+       */
 
 Review comment:
   The content looks fine. Please change this to use line comments (`//`) instead of block comments because this is in the middle of code. Also, please remove the javadoc formatting that isn't necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org