You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2009/10/30 05:37:00 UTC
[jira] Created: (HADOOP-6347) run-test-core-fault-inject runs a
test case twice if -Dtestcase is set
run-test-core-fault-inject runs a test case twice if -Dtestcase is set
----------------------------------------------------------------------
Key: HADOOP-6347
URL: https://issues.apache.org/jira/browse/HADOOP-6347
Project: Hadoop Common
Issue Type: Bug
Reporter: Konstantin Boudnik
When a testcase is specified through {{-Dtestcase=}} and {{run-test-core-fault-inject}} is executed then the same test case is ran twice. Apparently it has to be executed only one time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6347) run-test-core-fault-inject runs a
test case twice if -Dtestcase is set
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773023#action_12773023 ]
Hudson commented on HADOOP-6347:
--------------------------------
Integrated in Hadoop-Common-trunk #147 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/147/])
. run-test-core-fault-inject runs a test case twice if -Dtestcase is set. Contributed by Konstantin Boudnik
> run-test-core-fault-inject runs a test case twice if -Dtestcase is set
> ----------------------------------------------------------------------
>
> Key: HADOOP-6347
> URL: https://issues.apache.org/jira/browse/HADOOP-6347
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6347.patch, HADOOP-6347.patch, HADOOP-6347.patch
>
>
> When a testcase is specified through {{-Dtestcase=}} and {{run-test-core-fault-inject}} is executed then the same test case is ran twice. Apparently it has to be executed only one time.
> Also, it seems to be excessive to search for a fault injection test when {{run-fault-inject-with-testcaseonly}} is executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6347) run-test-core-fault-inject runs a
test case twice if -Dtestcase is set
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6347:
---------------------------------------
Description:
When a testcase is specified through {{-Dtestcase=}} and {{run-test-core-fault-inject}} is executed then the same test case is ran twice. Apparently it has to be executed only one time.
Also, it seems to be excessive to search for a fault injection test when {{run-fault-inject-with-testcaseonly}} is executed.
was:When a testcase is specified through {{-Dtestcase=}} and {{run-test-core-fault-inject}} is executed then the same test case is ran twice. Apparently it has to be executed only one time.
> run-test-core-fault-inject runs a test case twice if -Dtestcase is set
> ----------------------------------------------------------------------
>
> Key: HADOOP-6347
> URL: https://issues.apache.org/jira/browse/HADOOP-6347
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Konstantin Boudnik
>
> When a testcase is specified through {{-Dtestcase=}} and {{run-test-core-fault-inject}} is executed then the same test case is ran twice. Apparently it has to be executed only one time.
> Also, it seems to be excessive to search for a fault injection test when {{run-fault-inject-with-testcaseonly}} is executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6347) run-test-core-fault-inject runs a
test case twice if -Dtestcase is set
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6347:
---------------------------------------
Attachment: HADOOP-6347.patch
A comment is added to ease dependencies tracking.
> run-test-core-fault-inject runs a test case twice if -Dtestcase is set
> ----------------------------------------------------------------------
>
> Key: HADOOP-6347
> URL: https://issues.apache.org/jira/browse/HADOOP-6347
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Konstantin Boudnik
> Attachments: HADOOP-6347.patch, HADOOP-6347.patch, HADOOP-6347.patch
>
>
> When a testcase is specified through {{-Dtestcase=}} and {{run-test-core-fault-inject}} is executed then the same test case is ran twice. Apparently it has to be executed only one time.
> Also, it seems to be excessive to search for a fault injection test when {{run-fault-inject-with-testcaseonly}} is executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6347) run-test-core-fault-inject runs a
test case twice if -Dtestcase is set
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6347:
---------------------------------------
Attachment: HADOOP-6347.patch
A better one: makes injection compilation target depends on a special wrapper target which should be customized in any subprojects.
> run-test-core-fault-inject runs a test case twice if -Dtestcase is set
> ----------------------------------------------------------------------
>
> Key: HADOOP-6347
> URL: https://issues.apache.org/jira/browse/HADOOP-6347
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Konstantin Boudnik
> Attachments: HADOOP-6347.patch, HADOOP-6347.patch
>
>
> When a testcase is specified through {{-Dtestcase=}} and {{run-test-core-fault-inject}} is executed then the same test case is ran twice. Apparently it has to be executed only one time.
> Also, it seems to be excessive to search for a fault injection test when {{run-fault-inject-with-testcaseonly}} is executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6347) run-test-core-fault-inject runs a
test case twice if -Dtestcase is set
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772724#action_12772724 ]
Jakob Homan commented on HADOOP-6347:
-------------------------------------
New comments are fine. +1 on updated patch.
> run-test-core-fault-inject runs a test case twice if -Dtestcase is set
> ----------------------------------------------------------------------
>
> Key: HADOOP-6347
> URL: https://issues.apache.org/jira/browse/HADOOP-6347
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6347.patch, HADOOP-6347.patch, HADOOP-6347.patch
>
>
> When a testcase is specified through {{-Dtestcase=}} and {{run-test-core-fault-inject}} is executed then the same test case is ran twice. Apparently it has to be executed only one time.
> Also, it seems to be excessive to search for a fault injection test when {{run-fault-inject-with-testcaseonly}} is executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6347) run-test-core-fault-inject runs a
test case twice if -Dtestcase is set
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772727#action_12772727 ]
Hudson commented on HADOOP-6347:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #79 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/79/])
. run-test-core-fault-inject runs a test case twice if -Dtestcase is set. Contributed by Konstantin Boudnik
> run-test-core-fault-inject runs a test case twice if -Dtestcase is set
> ----------------------------------------------------------------------
>
> Key: HADOOP-6347
> URL: https://issues.apache.org/jira/browse/HADOOP-6347
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6347.patch, HADOOP-6347.patch, HADOOP-6347.patch
>
>
> When a testcase is specified through {{-Dtestcase=}} and {{run-test-core-fault-inject}} is executed then the same test case is ran twice. Apparently it has to be executed only one time.
> Also, it seems to be excessive to search for a fault injection test when {{run-fault-inject-with-testcaseonly}} is executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6347) run-test-core-fault-inject runs a
test case twice if -Dtestcase is set
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6347:
--------------------------------
Hadoop Flags: [Reviewed]
Before patch:
{noformat}[6980]shinytardis:hadoop-common(r6347) jhoman$ ant -Dtestcase=TestDU clean test | grep Running
[junit] Running org.apache.hadoop.fs.TestDU
[junit] Running org.apache.hadoop.fs.TestDU{noformat}
After patch:
{noformat}[6985]shinytardis:hadoop-common(r6347) jhoman$ ant -Dtestcase=TestDU clean test | grep Running
[junit] Running org.apache.hadoop.fs.TestDU
{noformat}
Looks good. +1.
> run-test-core-fault-inject runs a test case twice if -Dtestcase is set
> ----------------------------------------------------------------------
>
> Key: HADOOP-6347
> URL: https://issues.apache.org/jira/browse/HADOOP-6347
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Konstantin Boudnik
> Attachments: HADOOP-6347.patch, HADOOP-6347.patch
>
>
> When a testcase is specified through {{-Dtestcase=}} and {{run-test-core-fault-inject}} is executed then the same test case is ran twice. Apparently it has to be executed only one time.
> Also, it seems to be excessive to search for a fault injection test when {{run-fault-inject-with-testcaseonly}} is executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6347) run-test-core-fault-inject runs a
test case twice if -Dtestcase is set
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6347:
---------------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
0.21.0
Status: Resolved (was: Patch Available)
Thanks for the review, Jakob!
I have just committed this.
> run-test-core-fault-inject runs a test case twice if -Dtestcase is set
> ----------------------------------------------------------------------
>
> Key: HADOOP-6347
> URL: https://issues.apache.org/jira/browse/HADOOP-6347
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6347.patch, HADOOP-6347.patch, HADOOP-6347.patch
>
>
> When a testcase is specified through {{-Dtestcase=}} and {{run-test-core-fault-inject}} is executed then the same test case is ran twice. Apparently it has to be executed only one time.
> Also, it seems to be excessive to search for a fault injection test when {{run-fault-inject-with-testcaseonly}} is executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6347) run-test-core-fault-inject runs a
test case twice if -Dtestcase is set
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772721#action_12772721 ]
Hadoop QA commented on HADOOP-6347:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12423854/HADOOP-6347.patch
against trunk revision 831478.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/122/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/122/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/122/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/122/console
This message is automatically generated.
> run-test-core-fault-inject runs a test case twice if -Dtestcase is set
> ----------------------------------------------------------------------
>
> Key: HADOOP-6347
> URL: https://issues.apache.org/jira/browse/HADOOP-6347
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6347.patch, HADOOP-6347.patch, HADOOP-6347.patch
>
>
> When a testcase is specified through {{-Dtestcase=}} and {{run-test-core-fault-inject}} is executed then the same test case is ran twice. Apparently it has to be executed only one time.
> Also, it seems to be excessive to search for a fault injection test when {{run-fault-inject-with-testcaseonly}} is executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6347) run-test-core-fault-inject runs a
test case twice if -Dtestcase is set
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6347:
---------------------------------------
Assignee: Konstantin Boudnik
Status: Patch Available (was: Open)
Ready for a verification rounds
> run-test-core-fault-inject runs a test case twice if -Dtestcase is set
> ----------------------------------------------------------------------
>
> Key: HADOOP-6347
> URL: https://issues.apache.org/jira/browse/HADOOP-6347
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6347.patch, HADOOP-6347.patch, HADOOP-6347.patch
>
>
> When a testcase is specified through {{-Dtestcase=}} and {{run-test-core-fault-inject}} is executed then the same test case is ran twice. Apparently it has to be executed only one time.
> Also, it seems to be excessive to search for a fault injection test when {{run-fault-inject-with-testcaseonly}} is executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6347) run-test-core-fault-inject runs a
test case twice if -Dtestcase is set
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6347:
---------------------------------------
Attachment: HADOOP-6347.patch
This patch fixes both problems.
> run-test-core-fault-inject runs a test case twice if -Dtestcase is set
> ----------------------------------------------------------------------
>
> Key: HADOOP-6347
> URL: https://issues.apache.org/jira/browse/HADOOP-6347
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Konstantin Boudnik
> Attachments: HADOOP-6347.patch
>
>
> When a testcase is specified through {{-Dtestcase=}} and {{run-test-core-fault-inject}} is executed then the same test case is ran twice. Apparently it has to be executed only one time.
> Also, it seems to be excessive to search for a fault injection test when {{run-fault-inject-with-testcaseonly}} is executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.