You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Vis-halV (via GitHub)" <gi...@apache.org> on 2026/10/18 04:07:22 UTC
[PR] fix: quickstart SLF4J dependency scope [wicket]
Vis-halV opened a new pull request, #1684:
URL: https://github.com/apache/wicket/pull/1684
## Summary
Changed the slf4j-simple dependency in the quickstart archetype to test scope.
Including slf4j-simple at compile scope can bundle an additional SLF4J backend in generated WAR files, potentially conflicting with an application server's logging configuration.
Set slf4j-simple to test scope in the quickstart archetype POM.
Closes #1678.
## Testing
mvn dependency:tree -Dincludes=org.slf4j:slf4j-simplecls - passed
mvn -pl archetypes/quickstart -am test - passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: quickstart SLF4J dependency scope [wicket]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1684:
URL: https://github.com/apache/wicket/pull/1684#issuecomment-6269997765
## [Codecov](https://app.codecov.io/gh/apache/wicket/pull/1684?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 61.96%. Comparing base ([`9395042`](https://app.codecov.io/gh/apache/wicket/commit/9395042894555985f3dddc2516276757bbfd3142?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0636e11`](https://app.codecov.io/gh/apache/wicket/commit/0636e116cd197aad1c4fbb9b31b35ccb4e4bf21d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1684 +/- ##
============================================
- Coverage 61.96% 61.96% -0.01%
+ Complexity 11286 11284 -2
============================================
Files 1250 1250
Lines 48437 48437
Branches 6796 6796
============================================
- Hits 30014 30013 -1
Misses 15729 15729
- Partials 2694 2695 +1
```
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: quickstart SLF4J dependency scope [wicket]
Posted by "bitstorm (via GitHub)" <gi...@apache.org>.
bitstorm merged PR #1684:
URL: https://github.com/apache/wicket/pull/1684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org