You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2021/04/06 17:00:32 UTC

[kudu] branch master updated (879c1dd -> 7c99e81)

This is an automated email from the ASF dual-hosted git repository.

alexey pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git.


    from 879c1dd  [build] drop RHEL/CentOS 6 OpenSSL ABI change workaround
     new c79560a  [client] fix setting LookupRpcById's fields
     new 7c99e81  [java] fix log message typo in KuduTransaction::startKeepaliveHeartbeating()

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../src/main/java/org/apache/kudu/client/KuduTransaction.java         | 2 +-
 src/kudu/client/meta_cache.cc                                         | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

[kudu] 02/02: [java] fix log message typo in KuduTransaction::startKeepaliveHeartbeating()

Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 7c99e8178f5d3edf7cae627a2403e59903360819
Author: Alexey Serbin <al...@apache.org>
AuthorDate: Tue Apr 6 01:18:21 2021 -0700

    [java] fix log message typo in KuduTransaction::startKeepaliveHeartbeating()
    
    Change-Id: Ia35939753e55e8e307392bdcb288c27ba898e211
    Reviewed-on: http://gerrit.cloudera.org:8080/17275
    Tested-by: Kudu Jenkins
    Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
 .../src/main/java/org/apache/kudu/client/KuduTransaction.java           | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java b/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java
index 05a5616..2e7bf41 100644
--- a/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java
+++ b/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java
@@ -600,7 +600,7 @@ public class KuduTransaction implements AutoCloseable {
   private void startKeepaliveHeartbeating() {
     if (keepaliveEnabled) {
       LOG.debug("starting keepalive heartbeating with period {} ms (txn ID {})",
-          txnId, keepalivePeriodForTimeout(keepaliveMillis));
+          keepalivePeriodForTimeout(keepaliveMillis), txnId);
       doStartKeepaliveHeartbeating();
     } else {
       LOG.debug("keepalive heartbeating disabled for this handle (txn ID {})", txnId);

[kudu] 01/02: [client] fix setting LookupRpcById's fields

Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit c79560adb09b26da0037f3e018c0154fadf2105c
Author: Alexey Serbin <al...@apache.org>
AuthorDate: Tue Apr 6 00:55:52 2021 -0700

    [client] fix setting LookupRpcById's fields
    
    LookupRpcById::SendRpc() might be called again if retrying the call,
    so the parameters for the request should be set only once.  This patch
    moves setting the relevant fields of GetTabletLocationsRequestPB into
    the LookupRpcById's constructor to avoid duplicates in the
    GetTabletLocationsRequestPB::tablet_ids field upon retrying the RPC.
    
    Change-Id: I0eacbc67db5ce1ff32a4aff80150a6152b205f23
    Reviewed-on: http://gerrit.cloudera.org:8080/17274
    Tested-by: Alexey Serbin <as...@cloudera.com>
    Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
 src/kudu/client/meta_cache.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/kudu/client/meta_cache.cc b/src/kudu/client/meta_cache.cc
index 131795e..6f3d839 100644
--- a/src/kudu/client/meta_cache.cc
+++ b/src/kudu/client/meta_cache.cc
@@ -661,6 +661,8 @@ LookupRpcById::LookupRpcById(scoped_refptr<MetaCache> meta_cache,
       tablet_id_(tablet_id),
       meta_cache_(std::move(meta_cache)),
       remote_tablet_(remote_tablet) {
+  req_.add_tablet_ids(tablet_id_);
+  req_.set_intern_ts_infos_in_response(true);
 }
 
 void LookupRpcById::SendRpc() {
@@ -675,8 +677,6 @@ void LookupRpcById::SendRpc() {
 }
 
 void LookupRpcById::SendRpcSlowPath() {
-  req_.add_tablet_ids(tablet_id_);
-  req_.set_intern_ts_infos_in_response(true);
   AsyncLeaderMasterRpc::SendRpc();
 }