You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by ja...@apache.org on 2020/02/26 08:50:21 UTC

[incubator-iotdb] branch FileClosedDebug updated: add count print

This is an automated email from the ASF dual-hosted git repository.

jackietien pushed a commit to branch FileClosedDebug
in repository https://gitbox.apache.org/repos/asf/incubator-iotdb.git


The following commit(s) were added to refs/heads/FileClosedDebug by this push:
     new 8edcfd9  add count print
8edcfd9 is described below

commit 8edcfd94cbdd56f28314e5c837989d3b627dce36
Author: JackieTien97 <Ja...@foxmail.com>
AuthorDate: Wed Feb 26 16:50:06 2020 +0800

    add count print
---
 .../apache/iotdb/db/query/control/FileReaderManager.java   | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/server/src/main/java/org/apache/iotdb/db/query/control/FileReaderManager.java b/server/src/main/java/org/apache/iotdb/db/query/control/FileReaderManager.java
index 64b9638..47e66a0 100644
--- a/server/src/main/java/org/apache/iotdb/db/query/control/FileReaderManager.java
+++ b/server/src/main/java/org/apache/iotdb/db/query/control/FileReaderManager.java
@@ -123,11 +123,11 @@ public class FileReaderManager implements IService {
       AtomicInteger refAtom = refMap.get(entry.getKey());
 
       if (refAtom != null && refAtom.get() == 0) {
-//        try {
-//          reader.close("no reference");
-//        } catch (IOException e) {
-//          logger.error("Can not close TsFileSequenceReader {} !", reader.getFileName(), e);
-//        }
+        try {
+          reader.close("no reference");
+        } catch (IOException e) {
+          logger.error("Can not close TsFileSequenceReader {} !", reader.getFileName(), e);
+        }
         iterator.remove();
         refMap.remove(entry.getKey());
       }
@@ -189,9 +189,11 @@ public class FileReaderManager implements IService {
   void decreaseFileReaderReference(TsFileResource tsFile, boolean isClosed) {
     synchronized (this) {
       if (!isClosed && unclosedReferenceMap.containsKey(tsFile)) {
-        closedReferenceMap.get(tsFile).decrementAndGet();
+        unclosedReferenceMap.get(tsFile).decrementAndGet();
+        logger.error("closed file {} after decrementing, the count is {}", tsFile.getFile().getName(), closedReferenceMap.get(tsFile).get());
       } else if (closedReferenceMap.containsKey(tsFile)){
         closedReferenceMap.get(tsFile).decrementAndGet();
+        logger.error("closed file {} after decrementing, the count is {}", tsFile.getFile().getName(), closedReferenceMap.get(tsFile).get());
       }
     }
     tsFile.getWriteQueryLock().readLock().unlock();