You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2020/02/01 06:31:05 UTC
[GitHub] [dubbo] codecov-io commented on issue #5356: optimize : constant names should be all uppercase, separated by underscores

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5356?src=pr&el=h1) Report
> Merging [#5356](https://codecov.io/gh/apache/dubbo/pull/5356?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/b958dc5f31d999cf05dcc097bb269321d0dc920b?src=pr&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `72.44%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/5356/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/5356?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #5356      +/-   ##
============================================
+ Coverage     61.26%   61.42%   +0.16%     
- Complexity      423      491      +68     
============================================
  Files           923      926       +3     
  Lines         37572    37845     +273     
  Branches       5442     5461      +19     
============================================
+ Hits          23018    23247     +229     
- Misses        12067    12074       +7     
- Partials       2487     2524      +37
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5356?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/dubbo/config/ApplicationConfig.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQXBwbGljYXRpb25Db25maWcuamF2YQ==) | `84% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/dubbo/common/constants/CommonConstants.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uc3RhbnRzL0NvbW1vbkNvbnN0YW50cy5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...enter/support/nacos/NacosDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29uZmlnY2VudGVyL3N1cHBvcnQvbmFjb3MvTmFjb3NEeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...rpc/cluster/loadbalance/RoundRobinLoadBalance.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvUm91bmRSb2JpbkxvYWRCYWxhbmNlLmphdmE=) | `78.57% <100%> (+0.38%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dubbo/remoting/transport/netty4/NettyClient.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50LmphdmE=) | `71.01% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../rpc/cluster/configurator/parser/ConfigParser.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvY29uZmlndXJhdG9yL3BhcnNlci9Db25maWdQYXJzZXIuamF2YQ==) | `88.23% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/config/ReferenceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnQmFzZS5qYXZh) | `60.39% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dubbo/remoting/transport/netty4/NettyServer.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVyLmphdmE=) | `73.52% <100%> (+0.39%)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/ProtocolConfig.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUHJvdG9jb2xDb25maWcuamF2YQ==) | `91.26% <33.33%> (-1.42%)` | `0 <0> (ø)` | |
| [...n/java/org/apache/dubbo/config/ProviderConfig.java](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUHJvdmlkZXJDb25maWcuamF2YQ==) | `95.45% <33.33%> (-2.2%)` | `0 <0> (ø)` | |
| ... and [33 more](https://codecov.io/gh/apache/dubbo/pull/5356/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5356?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5356?src=pr&el=footer). Last update [b958dc5...b49584c](https://codecov.io/gh/apache/dubbo/pull/5356?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo/pull/5356 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org